Grids: type DataController.filter and the filter expression types - #34696
Open
anna-shakhova wants to merge 1 commit into
Open
Grids: type DataController.filter and the filter expression types#34696anna-shakhova wants to merge 1 commit into
anna-shakhova wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Grid Core DataController-related TypeScript typings, focusing on providing a more explicit filter type model and modernizing a couple of legacy patterns in DataController.
Changes:
- Reworked
data_controller/types.tsfilter-related types (introducedFilterCondition, recursiveFilterExpression, and a dedicatedMatchNothingFilter). - Updated
DataController.filterto use overloads + rest parameters instead ofarguments, and removed related ESLint disables. - Updated
fireErrorto use typed rest parameters and direct invocation (errors.Error(...args)) instead of.apply.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/data_controller/types.ts | Refactors/expands paging and filter type definitions (new filter expression model). |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts | Modernizes filter and fireError implementations and aligns with new filter typings. |
Comment on lines
+123
to
+125
| export type FilterCondition = [string, ScalarFilterValue] | ||
| | [string, SearchOperation, ScalarFilterValue] | ||
| | [string, MultiValueSearchOperation, ScalarFilterValue[]]; |
anna-shakhova
force-pushed
the
data_contr_fix_rest_spread_main
branch
from
August 7, 2026 15:15
d1e9db8 to
b20a301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.