Skip to content

CI: Remove workflow_call trigger from packages_publishing & use GH CLI for call - #34811

Merged
r-farkhutdinov merged 3 commits into
mainfrom
packages-publishing-scheduler-fix
Aug 18, 2026
Merged

r-farkhutdinov merged 3 commits into
mainfrom
packages-publishing-scheduler-fix

Conversation

@r-farkhutdinov

@r-farkhutdinov r-farkhutdinov commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR reverts:

  1. CI: Protect manual package publishing workflows #34733
  2. CI: Remove approve-package-publishing job from packages publishing #34783

After this change, the following logic applies:

  1. daily releases can only be published from a protected branch
  2. stable releases should be approved and can only be published from a protected branch

@r-farkhutdinov r-farkhutdinov self-assigned this Aug 18, 2026
@r-farkhutdinov
r-farkhutdinov requested a review from a team as a code owner August 18, 2026 11:28
Copilot AI lite review requested due to automatic review settings August 18, 2026 11:28
@r-farkhutdinov
r-farkhutdinov force-pushed the packages-publishing-scheduler-fix branch from 96b45ef to a615098 Compare August 18, 2026 11:30
@r-farkhutdinov
r-farkhutdinov had a problem deploying to packages-publishing-daily August 18, 2026 11:33 — with GitHub Actions Failure

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Packages publishing automation by removing the reusable workflow_call entry point from packages_publishing.yml and switching the scheduler to dispatch the publishing workflow via the GitHub CLI (gh workflow run) for each target branch.

Changes:

  • Removed the workflow_call trigger from .github/workflows/packages_publishing.yml and simplified environment selection to stable vs daily environments.
  • Reworked .github/workflows/packages_publishing_scheduler.yml to dispatch packages_publishing.yml via gh workflow run instead of uses: ./.github/workflows/....
  • Added a temporary pull_request trigger to the scheduler workflow (flagged as risky for publishing workflows).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/packages_publishing.yml Removes reusable-workflow entry point and updates job environment selection logic.
.github/workflows/packages_publishing_scheduler.yml Replaces reusable-workflow call with gh workflow run dispatch across release branches.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/packages_publishing_scheduler.yml Outdated
Comment thread .github/workflows/packages_publishing.yml
Copilot AI review requested due to automatic review settings August 18, 2026 11:33
@r-farkhutdinov
r-farkhutdinov had a problem deploying to packages-publishing-stable August 18, 2026 11:34 — with GitHub Actions Failure

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/packages_publishing_scheduler.yml:7

  • The workflow is now configured to run on every pull request. For a publishing scheduler, this is likely unintended and can cause unnecessary/failed publish attempts on PRs (especially from forks with restricted tokens). Align this with the existing scheduler pattern (schedule + optional workflow_dispatch) instead of pull_request.
on:
  schedule:
    - cron: '00 18 * * *'
  pull_request:

.github/workflows/packages_publishing_scheduler.yml:22

  • actions/checkout is configured with sparse-checkout: README.md but does not disable cone mode. In this repo, the same pattern uses sparse-checkout-cone-mode: false (see .github/workflows/codeql_scheduler.yml:19-25), otherwise the file pattern may not be applied as intended.
      - name: Get sources
        uses: actions/checkout@v6
        with:
          sparse-checkout: README.md

Copilot AI review requested due to automatic review settings August 18, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/workflows/packages_publishing_scheduler.yml:22

  • actions/checkout sparse checkout is configured to fetch a single file (README.md), but sparse-checkout-cone-mode is not set. In checkout’s default cone mode, file-only patterns like README.md can fail; the repo already uses sparse-checkout-cone-mode: false for this exact case in .github/workflows/codeql_scheduler.yml. Align this workflow to avoid sporadic checkout failures.
        uses: actions/checkout@v6
        with:
          sparse-checkout: README.md

Copilot AI review requested due to automatic review settings August 18, 2026 11:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/packages_publishing_scheduler.yml:12

  • This job now dispatches another workflow via gh workflow run, but the workflow no longer declares any permissions:. If the repo’s default GITHUB_TOKEN permissions are set to read-only, the dispatch can fail because workflow dispatch typically requires actions: write. Consider adding an explicit permissions: block to make this independent of repository defaults.
    runs-on: ubuntu-latest
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    strategy:

.github/workflows/packages_publishing_scheduler.yml:25

  • gh workflow run ... only triggers the target workflow and exits without waiting; this scheduled workflow can report success even if the actual publishing run fails. Consider logging the triggered run URL/ID and (if desired) waiting on its completion so failures surface on the scheduled run.
      - name: Publish Packages (${{ matrix.branch }})
        run: |
          gh workflow run packages_publishing.yml -f tag=daily --ref ${{ matrix.branch }}

@r-farkhutdinov
r-farkhutdinov added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 24e52eb Aug 18, 2026
102 checks passed
@r-farkhutdinov
r-farkhutdinov deleted the packages-publishing-scheduler-fix branch August 18, 2026 13:47
arman-boyakhchyan pushed a commit to arman-boyakhchyan/DevExtreme that referenced this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants