Skip to content

fix(sbom): add hashes for workspace packages - #35714

Merged
IlyaKhD merged 5 commits into
mainfrom
r-farkhutdinov/add-hashes-local-packages
Oct 15, 2026
Merged

IlyaKhD merged 5 commits into
mainfrom
r-farkhutdinov/add-hashes-local-packages

Conversation

@r-farkhutdinov

@r-farkhutdinov r-farkhutdinov commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

@r-farkhutdinov r-farkhutdinov self-assigned this Oct 15, 2026
Copilot AI balanced review requested due to automatic review settings October 15, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The external toolkit’s hash-writing contract and resulting release SBOMs remain unverified.

0 open findings

What changed in this PR

Adds hashes for workspace packages to generated software bills of materials (SBOMs).

Changes:

  • Uses existing tarballs or temporarily packs selected internal packages to supply missing hashes.
  • Applies hashes before copying the DevExtreme SBOM.
  • Enables explicit .ts import extensions.
File Description
packages/​sbom/​scripts/​tsconfig.json Allows .ts import extensions.
packages/​sbom/​scripts/​make.ts Integrates workspace hashing into SBOM generation.
packages/​sbom/​scripts/​add-workspace-hashes.ts Resolves tarballs, adds hashes, and cleans up temporary files.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/sbom/scripts/add-workspace-hashes.ts Outdated
Comment thread packages/sbom/scripts/add-workspace-hashes.ts Outdated
Comment thread packages/sbom/scripts/add-workspace-hashes.ts Outdated
Copilot AI balanced review requested due to automatic review settings October 15, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Missing metadata-generation prerequisites can cause standalone SBOM generation to fail on unbuilt checkouts.

1 open finding

🧠 Review effort: Balanced

Comment thread packages/sbom/scripts/add-workspace-hashes.ts Outdated
Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Integration with the external SBOM toolkit and generated release artifacts remains unverified.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

Comment thread packages/sbom/scripts/add-workspace-hashes.ts Outdated
Copilot AI balanced review requested due to automatic review settings October 15, 2026 15:02
@r-farkhutdinov
r-farkhutdinov force-pushed the r-farkhutdinov/add-hashes-local-packages branch from e7d2931 to 41e7205 Compare October 15, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The undefined hash lookup aborts generation, and the cache initializer never computes internal-package hashes.

2 open findings

🧠 Review effort: Balanced

Comment thread packages/sbom/scripts/add-workspace-hashes.ts Outdated
Comment thread packages/sbom/scripts/add-workspace-hashes.ts
Copilot AI balanced review requested due to automatic review settings October 15, 2026 15:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

End-to-end validation with the SBOM toolkit is still needed to confirm the generated integrity data.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 15, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Toolkit integration and generated metadata contents remain unverified end to end, requiring human validation of SBOM integrity.

0 open findings

🧠 Review effort: Balanced

@r-farkhutdinov
r-farkhutdinov added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 15, 2026
@IlyaKhD
IlyaKhD added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 9bb68e4 Oct 15, 2026
173 of 174 checks passed
@IlyaKhD
IlyaKhD deleted the r-farkhutdinov/add-hashes-local-packages branch October 15, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants