Repository navigation
Grids: type and refactor m_header_panel - #35717
Merged
anna-shakhova merged 3 commits intoOct 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports this behavior-preserving refactor with no unresolved issues; tests were not run.
0 open findings
What changed in this PR
Refactors the shared grid header panel with stronger TypeScript types and consolidates CSS class constants across grid features.
Changes:
- Adds explicit header-panel types and simplifies toolbar option handling.
- Extracts header-panel constants into a dedicated module.
- Replaces duplicated CSS constants with shared view constants.
Paths below are relative to packages/devextreme/js/__internal/grids/grid_core/.
| File | Description |
|---|---|
virtual_scrolling/m_virtual_scrolling.ts |
Uses shared row and column-line constants. |
virtual_scrolling/const.ts |
Removes duplicated CSS constants. |
views/m_rows_view.ts |
Uses centralized view constants. |
views/const.ts |
Defines shared view CSS constants. |
search/m_search.ts |
Uses the shared header-panel constant. |
row_dragging/m_row_dragging.ts |
Uses the shared rows-view constant. |
row_dragging/const.ts |
Removes the duplicated rows-view constant. |
master_detail/m_master_detail.ts |
Uses the shared row-lines constant. |
master_detail/const.ts |
Removes the duplicated row-lines constant. |
keyboard_navigation/utils.ts |
Uses the shared free-space-row constant. |
keyboard_navigation/m_keyboard_navigation.ts |
Uses shared view selectors. |
keyboard_navigation/const.ts |
Removes duplicated view constants. |
header_panel/m_header_panel.ts |
Strengthens types and simplifies option handling. |
header_panel/const.ts |
Extracts toolbar and header-panel constants. |
column_headers/m_column_headers.ts |
Uses shared wrapping and column-line constants. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anna-shakhova
marked this pull request as ready for review
October 15, 2026 12:40
bit-byte0
reviewed
Oct 16, 2026
bit-byte0
previously approved these changes
Oct 16, 2026
bit-byte0
approved these changes
Oct 16, 2026
anna-shakhova
enabled auto-merge
October 16, 2026 09:21
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.