Repository navigation
Grids: remove m_ prefix from rows_view, header_panel - #35739
Merged
anna-shakhova merged 3 commits intoOct 16, 2026
Merged
Conversation
anna-shakhova
marked this pull request as ready for review
October 16, 2026 10:50
anna-shakhova
enabled auto-merge
October 16, 2026 10:51
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports a behavior-preserving refactor with consistent references and no blocking issues; tests were not run.
0 open findings
What changed in this PR
Refactors shared DataGrid and TreeList internals by removing m_ prefixes from rows-view and header-panel modules and organizing grid-view code separately.
Changes:
- Updates imports and controller/view type references.
- Centralizes grid-view constants and reuses the adaptive hidden-width constant.
- Organizes grid-view tests, accessibility support, and documentation mappings.
Paths below are relative to packages/devextreme/js/__internal/grids/.
| File | Description |
|---|---|
tree_list/selection/m_selection.ts |
Updates RowsView import. |
tree_list/rows/m_rows.ts |
Updates rows-module imports. |
tree_list/module_not_extended/header_panel.ts |
Updates header-panel registration import. |
tree_list/m_virtual_scrolling.ts |
Updates RowsView import. |
tree_list/grid_view.ts |
Updates grid-view import and best-fit constant. |
tree_list/editing/m_editing.ts |
Updates RowsView import. |
grid_core/virtual_scrolling/m_virtual_scrolling.ts |
Updates view/controller imports. |
grid_core/virtual_columns/m_virtual_columns.ts |
Updates view/controller imports. |
grid_core/views/rows_view.ts |
Updates resizing-controller import. |
grid_core/views/columns_view.ts |
Reuses adaptive hidden-width constant. |
grid_core/validating/m_validating.ts |
Updates RowsView import. |
grid_core/types.ts |
Updates controller and view type paths. |
grid_core/sticky_columns/m_sticky_columns.ts |
Updates view imports. |
grid_core/state_storing/m_state_storing.ts |
Updates RowsView import. |
grid_core/sorting/m_sorting.ts |
Updates HeaderPanel import. |
grid_core/selection/m_selection.ts |
Updates RowsView import. |
grid_core/search/m_search.ts |
Updates panel and rows imports. |
grid_core/row_dragging/m_row_dragging.ts |
Reuses container constant and updates import. |
grid_core/master_detail/m_master_detail.ts |
Updates view/controller imports. |
grid_core/m_utils.ts |
Reuses adaptive hidden-width constant. |
grid_core/keyboard_navigation/m_keyboard_navigation.ts |
Updates RowsView import. |
grid_core/header_panel/header_panel.ts |
Updates resizing-controller import. |
grid_core/header_filter/m_header_filter.ts |
Updates HeaderPanel import. |
grid_core/grid_view/grid_view.ts |
Relocates grid view and extracts constants. |
grid_core/grid_view/const.ts |
Defines grid-view constants. |
grid_core/grid_view/a11y_status_container_component.ts |
Houses accessibility status component. |
grid_core/grid_view/__tests__/grid_view.normalize_widths_by_expand_columns.test.ts |
Covers expand-column width normalization. |
grid_core/grid_view/__tests__/grid_view.free_width.integration.test.ts |
Updates relocated test’s type import. |
grid_core/focus/m_focus.ts |
Updates RowsView import. |
grid_core/filter_row/m_filter_row.ts |
Updates HeaderPanel import. |
grid_core/error_handling/error_handling_view_controller.ts |
Updates view/controller imports. |
grid_core/editor_factory/m_editor_factory.ts |
Updates RowsView import. |
grid_core/editing/m_editing.ts |
Updates imports and hidden-width constant. |
grid_core/editing/m_editing_row_based.ts |
Updates RowsView import. |
grid_core/editing/m_editing_form_based.ts |
Updates RowsView import. |
grid_core/editing/m_editing_cell_based.ts |
Updates RowsView import. |
grid_core/columns_resizing_reordering/types.ts |
Updates HeaderPanel type import. |
grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts |
Updates panel and rows imports. |
grid_core/column_headers/m_column_headers.ts |
Updates HeaderPanel import. |
grid_core/column_fixing/m_column_fixing.ts |
Updates view/controller imports. |
grid_core/column_chooser/m_column_chooser.ts |
Updates panel and rows imports. |
grid_core/ai_assistant/ai_assistant_view_controller.ts |
Updates HeaderPanel import. |
grid_core/adaptivity/m_adaptivity.ts |
Updates RowsView import. |
grid_core/adaptivity/extenders/adaptivity_rows_view.ts |
Updates RowsView import. |
grid_core/adaptivity/extenders/adaptivity_resizing_view_controller.ts |
Updates resizing-controller import. |
data_grid/summary/m_summary.ts |
Updates RowsView import. |
data_grid/module_not_extended/rows.ts |
Updates rows-module registration import. |
data_grid/module_not_extended/header_panel.ts |
Updates header-panel registration import. |
data_grid/module_not_extended/grid_view.ts |
Updates grid-view registration import. |
data_grid/grouping/m_grouping.ts |
Updates panel and rows imports. |
data_grid/export/m_export.ts |
Updates panel and rows imports. |
__docs__/scripts/grid_core/constants.ts |
Maps grid-view directory to Core. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alyar666
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.