Repository navigation
Grids: remove m_ prefix from editor factory, editing utils, keyboard navigation and adaptivity files - #35740
Merged
bit-byte0 merged 2 commits intoOct 16, 2026
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The mechanical renames and corresponding references are consistent, with no unresolved blocking issues identified.
0 open findings
What changed in this PR
This PR removes the m_ prefix from selected internal grid modules, keeping DataGrid, TreeList, and shared grid references aligned.
Changes:
- Rename editor factory, editing utilities, adaptivity, and selected keyboard navigation modules.
- Update imports, controller registry types, and the affected test import.
- Update two comments to reflect renamed files.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/keyboardNavigation.keyboardController.tests.js | Update header navigation import. |
| packages/devextreme/js/__internal/grids/tree_list/module_not_extended/headers_keyboard_navigation.ts | Update TreeList navigation import. |
| packages/devextreme/js/__internal/grids/tree_list/module_not_extended/editor_factory.ts | Update TreeList editor factory import. |
| packages/devextreme/js/__internal/grids/new/grid_core/editing/popup/view.ts | Update form utilities import. |
| packages/devextreme/js/__internal/grids/new/grid_core/editing/controller.ts | Update editing utilities import. |
| packages/devextreme/js/__internal/grids/grid_core/views/grid_view.ts | Update controller type imports. |
| packages/devextreme/js/__internal/grids/grid_core/views/columns_view.ts | Update controller type imports. |
| packages/devextreme/js/__internal/grids/grid_core/validating/m_validating.ts | Update editor factory type import. |
| packages/devextreme/js/__internal/grids/grid_core/types.ts | Update controller registry paths. |
| packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts | Update controller type imports. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/utils.ts | Update navigation core type import. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts | Update adaptivity and navigation imports. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/keyboard_navigation_core.ts | Rename navigation core module. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/headers_keyboard_navigation.ts | Rename module and update base import. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/column_keyboard_navigation_core.ts | Rename module and update base import. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/column_focus_dispatcher.ts | Update navigation controller type import. |
| packages/devextreme/js/__internal/grids/grid_core/focus/m_focus.ts | Update editing and editor factory imports. |
| packages/devextreme/js/__internal/grids/grid_core/editor_factory/editor_factory.ts | Rename editor factory module. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts | Update editing utilities import. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing_form_based.ts | Update form editing utilities import. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing_cell_based.ts | Update cell editing utilities import. |
| packages/devextreme/js/__internal/grids/grid_core/editing/extenders/editing_data_controller.ts | Update modification helper import. |
| packages/devextreme/js/__internal/grids/grid_core/editing/editing_utils.ts | Rename editing utilities module. |
| packages/devextreme/js/__internal/grids/grid_core/context_menu/m_column_context_menu_mixin.ts | Update navigation controller type import. |
| packages/devextreme/js/__internal/grids/grid_core/columns_resizing_reordering/m_columns_resizing_reordering.ts | Update editor factory type import. |
| packages/devextreme/js/__internal/grids/grid_core/columns_controller/columns_controller.ts | Update adaptivity extension comment only. |
| packages/devextreme/js/__internal/grids/grid_core/column_headers/m_column_headers.ts | Update header navigation type import. |
| packages/devextreme/js/__internal/grids/grid_core/column_fixing/m_column_fixing.ts | Update editor factory type import. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_headers_keyboard_navigation_view_controller.ts | Update header navigation type import. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_editor_factory_view_controller.ts | Update editor factory type import. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_data_controller.ts | Update adaptivity controller type import. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_columns_controller.ts | Update adaptivity controller type import. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/adaptivity.ts | Rename adaptivity controller module. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/adaptivity_module.ts | Update adaptivity registration import. |
| packages/devextreme/js/__internal/grids/data_grid/widget.ts | Update group panel navigation import. |
| packages/devextreme/js/__internal/grids/data_grid/module_not_extended/editor_factory.ts | Update DataGrid editor factory import. |
| packages/devextreme/js/__internal/grids/data_grid/keyboard_navigation/types.ts | Update navigation base type import. |
| packages/devextreme/js/__internal/grids/data_grid/keyboard_navigation/headers_keyboard_navigation.ts | Update shared navigation and mixin imports. |
| packages/devextreme/js/__internal/grids/data_grid/keyboard_navigation/group_panel_keyboard_navigation.ts | Rename module and update dependencies. |
| packages/devextreme/js/__internal/grids/data_grid/keyboard_navigation/column_keyboard_navigation_mixin.ts | Rename column navigation mixin. |
| packages/devextreme/js/__internal/grids/__docs__/scripts/grid_core/resolver.ts | Update filename example in comment only. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… KBN and adaptivity files
bit-byte0
force-pushed
the
refactor/rename-editor-kbn-adaptivity-m-files-main
branch
from
October 16, 2026 12:26
ada66af to
e695167
Compare
anna-shakhova
approved these changes
Oct 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2026
bit-byte0
deleted the
refactor/rename-editor-kbn-adaptivity-m-files-main
branch
October 16, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed the
m_prefix from the editor factory, editing utils, keyboard navigation and adaptivity files and combined their class constantsHow
Renamed the files and updated imports, including the controller registry. Class constants of these modules are grouped into
CLASSESobjects in const.ts, duplicates are imported from the modules that own them