fix: Handle GET_SAMPLE_TEXT as requested by AOSP Settings - #50
Open
nchilada wants to merge 1 commit into
Open
Conversation
The Settings > Accessibility > Text-to-speech output > Play button confirms that TTS is working and helps the user modulate the Pitch and Speech Rate settings. Because the Supertonic TTS engine wasn't handling the `GET_SAMPLE_TEXT` intent, the Play button was visible and tappable but didn't play any audio, not even the default sentence. Internally, [`startActivityForResult`](https://android.googlesource.com/platform/packages/apps/Settings.git/+/7c598253ff60f06f8e6fe046f18fd88e9daa72d3/src/com/android/settings/tts/TextToSpeechSettings.java#493) was repeatedly throwing an error and spamming the logs with: ``` E TextToSpeechSettings: Failed to get sample text, no activity found for Intent { act=android.speech.tts.engine.GET_SAMPLE_TEXT xflg=0x4 pkg=com.brahmadeo.supertonic.tts (has extras) }) ```
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings > Accessibility > Text-to-speech output > Play button confirms that TTS is working and helps the user modulate the Pitch and Speech Rate settings.
Because the Supertonic TTS engine wasn't handling the
GET_SAMPLE_TEXTintent, the Play button was visible and tappable but didn't play any audio, not even the default sentence. Internally,startActivityForResultwas repeatedly throwing an error and spamming the logs with:Summary by CodeRabbit