[codex] Secure schedule finish authorization#291
Merged
Conversation
|
실패하는 테스트코드가 있어 PR이 자동으로 닫혔습니다. |
|
실패하는 테스트코드가 있어 PR이 자동으로 닫혔습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The finish endpoint ignored the path parameter and the service loaded the schedule directly from the request body UUID, so any authenticated user could finish another user's schedule if they knew or guessed its UUID.
Validation
Note: the focused ScheduleServiceTest class could not be executed locally because the Spring Boot test context attempted to connect to MySQL and the local connection was refused.
Closes #272