Improve the empty state when no collections exist - #23
Merged
DevOlabode merged 1 commit intoSep 18, 2026
Merged
DevOlabode merged 1 commit into
DevOlabode merged 1 commit into
Conversation
Make the no-collections guide name the next click, and focus the collection name field when the composer opens from that empty state. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
|
@dyk1454683243-sudo is attempting to deploy a commit to the solabode499-5056's projects Team on Vercel. A member of the Team first needs to authorize it. |
dyk1454683243-sudo
marked this pull request as ready for review
September 18, 2026 07:07
DevOlabode
approved these changes
Sep 18, 2026
DevOlabode
left a comment
DevOlabode
left a comment
Owner
There was a problem hiding this comment.
Reviewed the diff — logic checks out. focusComposerField() reads composerType correctly, and setComposerType() unhides #collection-fields before focus is called in both call sites (openComposer and the tab-click handler), so there's no race where the field is focused while still hidden. The new id="collection-name" and aria-describedby="collections-empty-copy" both resolve correctly. Build passes.
Approving; will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the popup empty state when a signed-in user has bookmarks but no collections.
The
#collections-emptyguide still explains that collections group related bookmarks. It now names the next click (Create a collectionbelow), and opening the composer from that empty state focuses the collection name field. Switching to the Collection tab does the same. This matches the bookmarks empty-state focus work from #8 / #20.Related Issue
Fixes #9
Type of Change
Screenshots
Verified in the popup UI:
#collection-name(orange focus ring,Frontendplaceholder)Checklist