feat: add popup keyboard shortcuts - #26
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Add Alt+Shift+S as a remappable command that opens the composer with the current http(s) tab, and Esc to close a form or return to the library, without overriding reserved browser chrome shortcuts. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
|
@cursoragent is attempting to deploy a commit to the solabode499-5056's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Withdrawing this PR while I clean up a high-volume open-PR backlog. Sorry for the noise — happy to come back later with a focused change if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a small, documented set of keyboard shortcuts for the extension popup. Mouse and touch behavior is unchanged.
Proposed shortcuts (justification)
Alt+Shift+S(Option+Shift+Son macOS)httporhttpsCtrl+T,Ctrl+W,Ctrl+L, andCtrl+Shift+B(bookmarks bar). Users can remap or disable it fromchrome://extensions/shortcutsoredge://extensions/shortcuts.EscaddForm/collectionAddForm). If no composer is open, go back from a collection or Account to the library. On the library with no form open, the browser still closes the popup.preventDefaultruns only when Curate handles the key, so the home view still dismisses like other extension popups.activeTabis used instead oftabs/historyso the current page is read only after a toolbar click or the command.Related Issue
Fixes #17
Type of Change
Testing
npm test) — 57 passing, including shortcut helpers and manifest command checksnpm run build:extension)Checklist