Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
We found a small regression in the model picker refactor that landed with the combined model and reasoning menu. When a
ModelSelectcaller does not provide its optionalonConfigureModelshandler, the wrapper still supplies an empty callback toModelListContent. That prevents the shared list from dispatching our normalopenModelPickerEvent, so Configure models can silently do nothing.This keeps the popover close behavior and explicitly dispatches the existing fallback event when there is no custom handler.
How we checked it
evawithmain; the branch adds one commit and changes onlyapps/app/src/components/model-select.tsx.evasource retains the custom callback path and restores the default event path.Reproduction
ModelSelectwithoutonConfigureModels.openModelPickerEventis dispatched.