Skip to content

Agent/opencode 1 18 3 video templates - #84

Open
Devin-AXIS wants to merge 14 commits into
mainfrom
agent/opencode-1-18-3-video-templates
Open

Agent/opencode 1 18 3 video templates#84
Devin-AXIS wants to merge 14 commits into
mainfrom
agent/opencode-1-18-3-video-templates

Conversation

@Devin-AXIS

Copy link
Copy Markdown
Owner

Summary

Why

Issue

  • Closes #

Scope

Out of scope

Testing

Ran

  • ...

Result

  • pass/fail:
  • if fail, exact files/errors:

CI status

  • pass:
  • code-related failures:
  • external/env/auth blockers:

Manual verification

Evidence

  • video/screenshot link, or N/A (docs-only)

Risk

Rollback

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7037c3b54d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const mime = resolveModelAttachmentMimeType(fileName, mimeType);
if (mime.startsWith("image/") || mime.startsWith("text/")) return true;
if (mime === "application/pdf" || mime === "application/json") return true;
if (OFFICE_MIME_TYPES.has(mime)) return true;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't pass Office files as model-readable file parts

When a selected opencode/AI SDK provider only supports the existing image/PDF/text file-part media types, this new true path accepts .docx/.xlsx/.pptx and the send path now forwards the raw Office MIME via attachmentMime instead of converting it to text or blocking it. Those providers reject the prompt with an unsupported file-part media type, and because the bad file part is saved in server-side session history, later prompts in the same session keep replaying the failure; keep these formats blocked unless there is a provider-specific conversion/upload path.

Useful? React with 👍 / 👎.

Comment on lines +801 to +804
if (
autoCollapsedSidebarRef.current &&
!sidebarOpen &&
expandedMainWorkspaceWidth >= AUTO_COLLAPSE_LEFT_SIDEBAR_WIDTH

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't reopen the sidebar while the right panel is open

After the left sidebar auto-collapses on a narrow window, this restore condition ignores the right panel width. If a user opens a right panel and then resizes to just leftSidebarWidth + 520 (for example ~790px with the default 260px sidebar and 520px panel), the sidebar reopens even though the chat area has essentially no remaining width, causing the layout to overflow/squash; the restore check needs to account for sidePanelOpen/browserPanelDefaultWidth too.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants