Agent/opencode 1 18 3 video templates - #84
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7037c3b54d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const mime = resolveModelAttachmentMimeType(fileName, mimeType); | ||
| if (mime.startsWith("image/") || mime.startsWith("text/")) return true; | ||
| if (mime === "application/pdf" || mime === "application/json") return true; | ||
| if (OFFICE_MIME_TYPES.has(mime)) return true; |
There was a problem hiding this comment.
Don't pass Office files as model-readable file parts
When a selected opencode/AI SDK provider only supports the existing image/PDF/text file-part media types, this new true path accepts .docx/.xlsx/.pptx and the send path now forwards the raw Office MIME via attachmentMime instead of converting it to text or blocking it. Those providers reject the prompt with an unsupported file-part media type, and because the bad file part is saved in server-side session history, later prompts in the same session keep replaying the failure; keep these formats blocked unless there is a provider-specific conversion/upload path.
Useful? React with 👍 / 👎.
| if ( | ||
| autoCollapsedSidebarRef.current && | ||
| !sidebarOpen && | ||
| expandedMainWorkspaceWidth >= AUTO_COLLAPSE_LEFT_SIDEBAR_WIDTH |
There was a problem hiding this comment.
Don't reopen the sidebar while the right panel is open
After the left sidebar auto-collapses on a narrow window, this restore condition ignores the right panel width. If a user opens a right panel and then resizes to just leftSidebarWidth + 520 (for example ~790px with the default 260px sidebar and 520px panel), the sidebar reopens even though the chat area has essentially no remaining width, causing the layout to overflow/squash; the restore check needs to account for sidePanelOpen/browserPanelDefaultWidth too.
Useful? React with 👍 / 👎.
Summary
Why
Issue
Scope
Out of scope
Testing
Ran
...Result
CI status
Manual verification
Evidence
N/A (docs-only)Risk
Rollback