Repository navigation
Preserve installer arguments during package import - #52
Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits intoOct 19, 2026
Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
Conversation
…tialOverrideArguments` from an imported package entry reach installer dispatch in both the Rust and .NET CLIs. The mapping is generic and does not special-case VC++ packages.
… `Scope` into the install request. Update request construction in both Rust and .NET CLIs to ensure proper handling of `InitialCustomSwitches` and `InitialOverrideArguments`.
Contributor
Author
|
Hey Richard Markiewicz (@thenextman) could you please help here? Whats the correct workflow? How to proceed here? |
Member
Hi theKBro (@theKBro)! Thanks for the contributions. These seem to have slipped under the radar. I'm tagging the appropriate people internally. |
Contributor
|
theKBro (@theKBro) you can tag me if PRs get stuck for a while, I'll be looking into merging your PRs today |
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Oct 19, 2026
Marc-André Moreau (mamoreau-devolutions)
merged commit Oct 19, 2026
96378d1
into
Devolutions:master
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves per-package installation options from import JSON in both the Rust and .NET CLIs, instead of dropping them when constructing installation requests. The mapping is generic and does not special-case VC++ packages.
InitialCustomSwitchesInitialOverrideArgumentsScopeChannelRust constructs the request before the initial repository search, so that search also uses the imported scope and channel. .NET uses a dedicated import request factory to carry the options into installation.
Adds regression coverage for custom and override arguments, scope/channel mapping, and imports without optional fields. Existing silent-with-progress mode, package-agreement handling, and
--no-upgradebehavior are retained.Related issue
Fixes #49.