Skip to content

docs: lead with the install script and drop a triplicated MCP paragraph - #378

Merged
YoungJinJung merged 1 commit into
mainfrom
docs/issue-377-install-order-and-mcp-duplication
Sep 29, 2026
Merged

YoungJinJung merged 1 commit into
mainfrom
docs/issue-377-install-order-and-mcp-duplication

Conversation

@YoungJinJung

@YoungJinJung YoungJinJung commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

1. Install Script now comes first

Homebrew needs three commands and a trust decision since Homebrew 6.0.0 (#369). The script is one line with no trust step:

curl -sSL https://raw.githubusercontent.com/DevopsArtFactory/unic/main/install.sh | sh

Both paths stay documented; only the order changes.

This does not close #376. That asks for one-command brew install unic via homebrew-core, which is gated on notability (17 stars against a 225-star self-submission bar) and would also move release delivery off our tag push onto homebrew-core PRs. Reordering is the part available today.

Checked the one sentence that depends on ordering — line 181, "Install it with Homebrew or the install script above" — still correct, since both sections remain above it.

2. A triplicated paragraph, which was my regression

README.md repeated "The server provides/exposes the read-only resource operations listed above ..." three times in a row, each with its own example-prompt list.

This came from merging the #360 fills serially. #364, #367 and #368 each edited that sentence to name their own tool, and my conflict resolutions for #367 and #368 took both sides instead of merging them. Same class of defect as #317, and caused the same way.

Collapsed to one paragraph with the union of the prompts — six distinct lines, with the two that appeared in all three copies deduplicated:

- Show the AWS capabilities available through unic.
- List my AWS Backup vaults in ap-northeast-2.
- Show my deepest SQS backlogs and their dead-letter queue relationships.
- Show failed or rollback CloudFormation stacks and their status reasons.
- Show the recent failed executions for this STANDARD Step Functions state machine ARN.
- Preview a unic context sync without changing config.

The surviving sentence deliberately names no example tool. Naming one is exactly what made this line conflict on every single fill, and the command list above it already enumerates them — so this should stop recurring.

Validation

  • Scanned the whole README for any other repeated long line: none remain
  • go build ./... and go test ./... pass, though this change touches only Markdown

Closes #377

Summary by CodeRabbit

  • Documentation
    • Updated the Installation section to document the install script before Homebrew; other installation instructions and caveats remain unchanged.
    • Updated the Kiro example prompts to include a query for CloudFormation stack status.

Put Install Script before Homebrew under Installation. The Homebrew path
needs three commands and a trust decision since Homebrew 6.0.0 (#369);
the script is one line with no trust step, so it is the lower-friction
entry point for a first-time reader. Both remain documented.

This does not close #376 — that asks for one-command `brew install
unic`, which is gated on homebrew-core notability — but it is the part
available today.

Also collapses the "The server provides the read-only resource
operations listed above ..." paragraph, which appeared three times in a
row with three different example-prompt lists. That was a regression
from merging the #360 fills serially: #364, #367 and #368 each edited
the sentence to name their own tool, and the conflict resolutions for
#367 and #368 kept both sides rather than merging them. The surviving
sentence names no example tool, since doing so is what made the line
conflict on every fill and the command list above already enumerates
them. The six distinct prompts are preserved.

Closes #377
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: DevopsArtFactory/unic/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 704e69d2-0e70-4ff3-a7c8-45e1caa98893

📥 Commits

Reviewing files that changed from the base of the PR and between c38984b and b4c700c.

📒 Files selected for processing (1)
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: test
  • GitHub Check: Amazon Q Developer
  • GitHub Check: scan
🧰 Additional context used
📓 Path-based instructions (3)
Verify that README changes match actual CLI/TUI behavior and that Currently Implemented Features, TUI Key Bindings, Usage, and Configuration content stay aligned with code changes.

⚙️ CodeRabbit configuration file

Files:

  • README.md
Source excerpt: **피쳐를 추가, 수정, 삭제할 때 반드시 `README.md`를 함께 업데이트한다.**

📄 CodeRabbit inference engine (CLAUDE.md)

Files:

  • README.md
When implementation changes affect user-visible behavior, config/auth behavior, service coverage, TUI flow, or contributor workflow: update `README.md` update the relevant file under `docs/` use [`docs/documentation-harness.md`](docs/docume...

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • README.md
🔇 Additional comments (1)
README.md (1)

42-62: LGTM!

Also applies to: 264-264


Walkthrough

The README now places the Install Script instructions before Homebrew and includes a Kiro prompt for finding failed or rollback CloudFormation stacks and their status reasons.

Changes

README updates

Layer / File(s) Summary
Installation order and Kiro example
README.md
The Install Script and Homebrew subsections swap order; their commands and notes are unchanged. A Kiro example prompt is added for finding failed or rollback CloudFormation stacks and their status reasons.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b4c70

The README updates preserve valid installation guidance and consolidate the MCP examples; no merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to b4c70

The change affects 1 system.

Changed systems: README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: The Install Script and Homebrew subsections have swapped order; their commands and installation notes are unchanged.
  • observed — Modified behavior in README.md: A Kiro example prompt was added for finding failed or rollback CloudFormation stacks and their status reasons.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #377 is implemented. README.md places ### Install Script before ### Homebrew, keeps both options, preserves the install-script wording, and merges the three MCP sections into one paragraph… Keep #376 open until the notability requirement is met. Then submit the unic formula to homebrew-core and make the required source-build and release-pipeline changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required docs: conventional prefix and accurately describes both README changes.
Description check ✅ Passed The description explains the changes, rationale, related issue, and validation results. It omits the template checklist, but the required change and validation details are otherwise complete.
Out of Scope Changes check ✅ Passed The reviewed diff changes only README.md. The installation reorder and MCP prompt consolidation directly implement #377. The retained Homebrew instructions and the install-script wording support the…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #377 is implemented. README.md places ### Install Script before ### Homebrew, keeps both options, preserves the install-script wording, and merges the three MCP sections into one paragraph with six distinct prompts. The diff does not provide a duplicate-paragraph check beyond the README change, but the resulting reviewed README shows the targeted MCP duplication removed. Issue #376 remains unmet: the PR does not submit unic to homebrew-core, add a core formula, or change the release pipeline. The issue states that this work waits for the notability threshold, and the PR description also states that #376 remains open.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation PR successfully accomplishes both stated objectives: reordering the installation methods to lead with the simpler one-line install script, and removing the triplicated MCP paragraph that resulted from merge conflicts. The consolidation correctly preserves all unique example prompts, and the cross-reference on line 181 remains accurate. No defects found.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@YoungJinJung
YoungJinJung merged commit b2f2c8f into main Sep 29, 2026
4 checks passed
@YoungJinJung
YoungJinJung deleted the docs/issue-377-install-order-and-mcp-duplication branch September 29, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: lead with the install script and drop a triplicated MCP paragraph [Feature] Submit unic to homebrew-core so installs don't need brew trust

1 participant