Fix tests and clean up components#248
Open
lookangela wants to merge 5 commits intoyueci/adapt-dexsim-v0.4.0from
Open
Fix tests and clean up components#248lookangela wants to merge 5 commits intoyueci/adapt-dexsim-v0.4.0from
lookangela wants to merge 5 commits intoyueci/adapt-dexsim-v0.4.0from
Conversation
…ce/EmbodiChain into yueci/adapt-dexsim-v0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the simulation resource management, test stability, and device compatibility in the EmbodiChain simulation framework. The core changes revolve around robust destruction and cleanup of simulation scenes and assets, especially in Python test environments where C++ resources may otherwise leak or persist due to reference cycles. Additionally, there are targeted fixes for device handling and configuration defaults.
Resource management and cleanup improvements:
SimulationManager, along withwait_scene_destructionandflush_cleanup_queuemethods, to ensure C++ simulation scenes are fully destroyed and Python references are cleared, preventing resource leaks and test flakiness. This is now integrated into the test teardown process globally and in individual test classes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Device and tensor handling fixes:
contact_sensor.pyare created or moved to the correct device, preventing device mismatch errors. [1] [2]is_use_gpu_physicsproperty to check only the device type, simplifying logic and avoiding dependency on global configuration state.Test configuration and reliability:
"hybrid"for all tests, and added conditional skips for camera tests to ensure compatibility with the selected renderer. [1] [2]Minor fixes and configuration adjustments:
SDFConfiginsim_utils.pyfor external use.These changes collectively improve the robustness, reliability, and maintainability of both the simulation engine and its test suite.