Repository navigation
Add new scan selector - #256
Merged
Merged
Conversation
echen-dls
marked this pull request as ready for review
October 29, 2026 10:02
yousefmoazzam
left a comment
yousefmoazzam
left a comment
Collaborator
There was a problem hiding this comment.
The new scan browser looks great, thanks for this!
Only two small questions from me.
yousefmoazzam
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new scan selector has been added that displays the scan IDs associated with a session.
As only a couple of sessions currently have this data available, the original scan selector is still available as a fallback option. The sessions where the new scan selector can be used are:
To make this work, the ULIMS GraphQL schema has been updated, and some accompanying code (in
beamline.config.ts) has been added for scan metadata display. The metadata display will be added in the future.