I15-1: Show playlists from selected session - #150
Conversation
EmsArnold
left a comment
EmsArnold
left a comment
There was a problem hiding this comment.
One change which would be good to make, and some slight comments which can be overlooked.
| }; | ||
| }); | ||
|
|
||
| const mockedUseSubmitTask = queueService.useSumbitQueueTask as unknown as Mock; |
There was a problem hiding this comment.
Nit: mocked variables should either be mockUse... or mockedUse..., to be consistent. I believe there is some special case for mock... in Vitest, though obviously mocked... likely matches the pattern that Vitest looks for.
There was a problem hiding this comment.
I agree. It looks like we currently have a mix throughout the codebase but mostly look consistent within a file. Fixing this across the board feels out of scope for this PR though, I have made #155
| ); | ||
| }; | ||
|
|
||
| export function parseInstrumentSession( |
There was a problem hiding this comment.
Should: Rather than adding an additional function, you could use visitTextToVisit from app-shell/src/utils, which parses the visit text into a visit, which you can then pull the proposal number and session number out of. This may need to be exported.
If this is something which needs to be done more regularly, we should likely look at adding this into sci-react-ui as well.
There was a problem hiding this comment.
Thanks, I've updated to use visitTextToVisit. I think #156 might be a nicer solution but seems out of scope
2 participants
Fixes #149
To test: