Skip to content

ViSR: replace camera view with actual video feed from dcam3 - #158

Open
tomkane-dls wants to merge 5 commits into
mainfrom
pvws-tomoo-viewer
Open

ViSR: replace camera view with actual video feed from dcam3#158
tomkane-dls wants to merge 5 commits into
mainfrom
pvws-tomoo-viewer

Conversation

@tomkane-dls

Copy link
Copy Markdown
Contributor

Implementing pva to video:
https://github.com/diamondlightsource/pva-to-video/pkgs/container/pva-to-video

to get the real camera stream

@tomkane-dls
tomkane-dls marked this pull request as ready for review August 14, 2026 16:31
@tomkane-dls tomkane-dls changed the title replace camera view with actual video feed from dcam3 ViSR: replace camera view with actual video feed from dcam3 Aug 14, 2026
@Abigail-Yates

Copy link
Copy Markdown
Collaborator

Do we not want the 'camera view' text and the divider lines anymore?

@Abigail-Yates

Copy link
Copy Markdown
Collaborator

As discussed this morning, to make the 'SliceViewer' and 'VolumeViewer' more generic, I have removed the titles and borders from these files and moved this to the point where they are mapped in TomographyPlots.
image

@tomkane-dls

Copy link
Copy Markdown
Contributor Author

Hmm now I look at what we have, i think we can actually remove VolumeViewer entirely as it just seems like a nested redundant file and end up with:

  const views = [
    <img
      ...
    />,
    <VolumeRenderer
      ...
    />,
    <SliceViewer
      ...
    />,
  ];

This will keep it as three generic components with titles. I will also create an issue to add revolve: in the future

@Abigail-Yates

Abigail-Yates commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Hmm now I look at what we have, i think we can actually remove VolumeViewer entirely as it just seems like a nested redundant file

Good point - if the run/reset buttons are being removed (as in the other PR) it is not needed.

@tomkane-dls

Copy link
Copy Markdown
Contributor Author

Yes perfect we can forget about the visibility for now, just serve the example data straight away, and cross that bridge when we have the workflow working

@EmsArnold EmsArnold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, but I have a question about the implementation.

Comment on lines +37 to +40
<img
src="https://visr-pvws.diamond.ac.uk/mjpg/BL01B-DI-CAM-01:PVA:OUTPUT"
alt="Detector"
/>,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a benefit to just using an img over something more complex like the webcam from cs-web-lib (already in use in i15-1 app)?

Additionally, there is currently no handler for this, so MSW complains when testing locally. Would be good to mock this somehow and handle errors if the stream is ever unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants