ViSR: replace camera view with actual video feed from dcam3 - #158
ViSR: replace camera view with actual video feed from dcam3#158tomkane-dls wants to merge 5 commits into
Conversation
|
Do we not want the 'camera view' text and the divider lines anymore? |
|
Hmm now I look at what we have, i think we can actually remove VolumeViewer entirely as it just seems like a nested redundant file and end up with: This will keep it as three generic components with titles. I will also create an issue to add revolve: in the future |
Good point - if the run/reset buttons are being removed (as in the other PR) it is not needed. |
|
Yes perfect we can forget about the visibility for now, just serve the example data straight away, and cross that bridge when we have the workflow working |
EmsArnold
left a comment
There was a problem hiding this comment.
Looks sensible, but I have a question about the implementation.
| <img | ||
| src="https://visr-pvws.diamond.ac.uk/mjpg/BL01B-DI-CAM-01:PVA:OUTPUT" | ||
| alt="Detector" | ||
| />, |
There was a problem hiding this comment.
Is there a benefit to just using an img over something more complex like the webcam from cs-web-lib (already in use in i15-1 app)?
Additionally, there is currently no handler for this, so MSW complains when testing locally. Would be good to mock this somehow and handle errors if the stream is ever unavailable.

Implementing pva to video:
https://github.com/diamondlightsource/pva-to-video/pkgs/container/pva-to-video
to get the real camera stream