Align FIB and tomography images - #280
Merged
Merged
Conversation
- Updated ISPyB query to also return the Proposal and BLSession tables - Added 'save_dir' as an optional key to the AlignImagesParameters Pydantic model; this allows us to use the service with images that haven't been registered into ISPyB, which would facilitate testing" - Implemented image registratino for the FIB-TEM case, and saves output images and tables to a new folder under the reference image's 'processed' directory
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 83.14% 83.18% +0.03%
==========================================
Files 75 75
Lines 9334 9415 +81
Branches 1268 1272 +4
==========================================
+ Hits 7761 7832 +71
- Misses 1080 1088 +8
- Partials 493 495 +2 🚀 New features to boost your workflow:
|
- Make all keys in the AlignImagesParameters model optional - Add pixel size and experiment type keys to the model - Adjust the service logic so that the if the two atlas IDs are provided, it will get the image paths, pixel sizes, and save directory using ISPyB values; if not, it will the values provided in the Pydantic model (all relevant values must be provided)
…eters for updating
stephen-riggs
approved these changes
Jul 13, 2026
…eeds/fails is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further updates to the image correlation service's functionality.
ProposalandBLSessionare also returned, from which the visit names can then be constructed4e-6. Currently, it will save the image processing output to a folder named after the moving image's visit name and atlas file name. e.g.".../cm12345-1/processed/correlation/cm12345-2/atlas/..."