Skip to content

Safer exception handling in 'process_recipe' service - #281

Merged
tieneupin merged 1 commit into
mainfrom
safe-processing-recipe
Jul 15, 2026
Merged

Safer exception handling in 'process_recipe' service#281
tieneupin merged 1 commit into
mainfrom
safe-processing-recipe

Conversation

@tieneupin

Copy link
Copy Markdown
Contributor

We discovered a bug in the exception handling logic of the process_recipe service when it tries and fails to look for an existing recipe. It will try to reject the message with transport=rw.transport, which will error if the recipe wrapper variable is set to None.

This PR makes the exception handling logic safer by letting the service default to using the Transport class set by self._transport when rejecting the message.

@tieneupin
tieneupin requested a review from stephen-riggs July 15, 2026 08:55
@tieneupin tieneupin self-assigned this Jul 15, 2026
@tieneupin tieneupin added the bug Something isn't working label Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.21%. Comparing base (cdcc32e) to head (c9399df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          75       75           
  Lines        9437     9437           
  Branches     1276     1276           
=======================================
  Hits         7853     7853           
  Misses       1088     1088           
  Partials      496      496           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
tieneupin merged commit ac03b57 into main Jul 15, 2026
12 checks passed
@tieneupin
tieneupin deleted the safe-processing-recipe branch July 15, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants