Safer exception handling in 'process_recipe' service - #281
Merged
Conversation
stephen-riggs
approved these changes
Jul 15, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 75 75
Lines 9437 9437
Branches 1276 1276
=======================================
Hits 7853 7853
Misses 1088 1088
Partials 496 496 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered a bug in the exception handling logic of the
process_recipeservice when it tries and fails to look for an existing recipe. It will try to reject the message withtransport=rw.transport, which will error if the recipe wrapper variable is set toNone.This PR makes the exception handling logic safer by letting the service default to using the Transport class set by
self._transportwhen rejecting the message.