Membrain-seg should generate binned mrc itself - #295
Open
stephen-riggs wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 83.06% 83.36% +0.29%
==========================================
Files 76 77 +1
Lines 9584 9936 +352
Branches 1289 1384 +95
==========================================
+ Hits 7961 8283 +322
- Misses 1120 1140 +20
- Partials 503 513 +10 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than generating all the binned mrc files in the easymode service, we should do the membrain one in that service. This means we can display the 3D visualisation for SXT where easymode does not run.
Most of the diff here is just moving the
generate_binned_mrcfunction into a new file (the function itself is unchanged).