groupbox to change colours when in darkmode - #229
Merged
Conversation
abigailalexander
left a comment
abigailalexander
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for spotting Group Box was missing the class theming! Looking at this change, why are we not just adding the useStyles hook into the widget like the others?
Also, cs-web-lib should have no knowledge of custom class names that we are setting ourselves. All classfile logic should come from the parsed classfile and widget class name and be handled in useStyles, and we shouldn't be manually setting any colour themes that aren't explicit in Phoebus
Collaborator
Author
|
I'll make that change right now, thanks for the heads up |
abigailalexander
requested changes
Aug 17, 2026
abigailalexander
left a comment
abigailalexander
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, just a few more very minor changes
abigailalexander
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The groupbox component does not use the useStyles, hook, So I've had to make some additions to if the system is in darkmode to change selected colours.