Added script to generate version file from package.json - #231
Merged
Conversation
abigailalexander
approved these changes
Aug 14, 2026
abigailalexander
left a comment
abigailalexander
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me and works locally, thanks! I tested with the Daedalus branch One thing to check: the CI which builds and releases to npm doesn't include the npm run all-checks step, so I suspect the released version might not include the version.ts file like we expect. Could you add a step to run npm run generate-version in the npm publish CI?
abigailalexander
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried other methods of versioning and exporting that for Daedalus to use. This method requires having a prerollup script that does the creating of a versioning file, whose variables are then exported.