Add authentication to the queue - #86
Open
jacob-williamson wants to merge 21 commits into
Open
Conversation
jacob-williamson
marked this pull request as draft
August 12, 2026 08:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 98.76% 98.87% +0.11%
==========================================
Files 18 20 +2
Lines 889 979 +90
==========================================
+ Hits 878 968 +90
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jacob-williamson
marked this pull request as ready for review
August 14, 2026 11:51
jacob-williamson
force-pushed
the
2_auth
branch
from
August 14, 2026 13:21
ddbb8c8 to
6a11bf4
Compare
jacob-williamson
force-pushed
the
2_auth
branch
from
August 14, 2026 13:27
6a11bf4 to
11f38ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Adds authentication to the queue. Another ticket should be created to improve authorisation, taking account what visits users have access to etc. For now we just have a whitelist of approved fedIDs.
The user who queued a task is now also added to the task object, so this can now be displayed in the UI.
Instructions on how to test:
daq-queuing-service --config tests/system_tests/config_with_auth.yaml -p 8001 --devhealthzandget_queue_state, and the messagenot authenticatedis returnedInspectKEYCLOAK_TOKENkeyTesting authorisation:
tests/system_tests/config_with_auth.yamlget_config, you get a not authorised error.authorisation_whitelist