Select glob search strings when downloading upstream visits - #77
Merged
Conversation
…t of search strings to backend
…elect which search patterns they will download files with
d-j-hatton
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously introduced the
UpstreamVisitsCardcomponent, which enabled users to trigger the download of data from past visits belonging to the same proposal. This process involved performing glob searches in the backend using a pre-configured list of search patterns. There was no option to skip search patterns that are not relevant to the user's current needs.This PR updates the
UpstreamVisitsCardcomponent so that upon clicking on a visit to download, users can now view the search strings configured for that visit type, and select only the ones they want to use to find and download files with. The MachineConfig schema was also manually updated to include some of the newer keys introduced on the backend side.This PR is tied to DiamondLightSource/python-murfey#835 . Both should be rolled out in tandem.