Skip to content

Request processing of lamella evaluation images - #846

Merged
tieneupin merged 11 commits into
mainfrom
process-lamella-evaluation-images
Jul 29, 2026
Merged

Request processing of lamella evaluation images#846
tieneupin merged 11 commits into
mainfrom
process-lamella-evaluation-images

Conversation

@tieneupin

@tieneupin tieneupin commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Lamella evaluation images are high-resolution images of the sites during the last stages of the milling process. These images should be the ones displayed on the PATo frontend when users click on regions of interest on the atlas, in a similar vein to the CLEM workflow.

This PR adds logic to the FIBContext to submit a POST request to the backend when it detects a lamella evaluation image. An API endpoint and a workflow module have also been set up on the backend to eventually process the received message. The processing logic will be refined in subsequent PRs, and currently just exists as a placeholder.

Actual code diff is +117/-21, with the rest of the changes being due to the addition and modification of tests.

@tieneupin tieneupin self-assigned this Jul 28, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component client Relates to the client component fib Part of the FIB pipeline extension labels Jul 28, 2026
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.55%. Comparing base (f8c4814) to head (488f75f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   54.44%   54.55%   +0.11%     
==========================================
  Files         103      104       +1     
  Lines       11049    11078      +29     
  Branches     1467     1470       +3     
==========================================
+ Hits         6016     6044      +28     
- Misses       4713     4714       +1     
  Partials      320      320              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-j-hatton d-j-hatton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@tieneupin
tieneupin merged commit ce27d2a into main Jul 29, 2026
14 checks passed
@tieneupin
tieneupin deleted the process-lamella-evaluation-images branch July 29, 2026 01:55
d-j-hatton pushed a commit that referenced this pull request Aug 6, 2026
* Created API endpoint to trigger the FIB lamella evaluation images workflow
* Added placeholder workflow to register lamella evaluation images with
* Added logic to FIBContext to detect and register lamella evaluation images
* Moved the '_get_source' and '_file_transferred_to' logic into the class functions that need them
* Updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants