Remove call to nonexistent endpoint - #865
Open
d-j-hatton wants to merge 6 commits into
Open
Conversation
…that the tag may have changed when moving from just an atlas to a data collection
… configured from the murfey security configuration for convenience
…e deosn't exist. just do it directly, you're in the server anyway
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
- Coverage 54.64% 53.98% -0.67%
==========================================
Files 104 104
Lines 11159 11518 +359
Branches 1475 1579 +104
==========================================
+ Hits 6098 6218 +120
- Misses 4741 4947 +206
- Partials 320 353 +33 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Aug 18, 2026
Comment on lines
22
to
29
Contributor
There was a problem hiding this comment.
This function is repeated in almost every module where SmartEM is used. I wonder if it's worth breaking it out into a helper function in a module in murfey.util or smartem_backend.
tieneupin
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in #863. Currently it tries to do a database update through an endpoint that doesn't exist but as it is part of the API it should just do the update itself.