Fix fake index assertion callback semantics#2
Merged
Conversation
stevebauman
marked this pull request as ready for review
July 24, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
assertCreated()match the recorded index by name when no callback is provided.assertCreated(),assertMappingPut(), andassertSettingsPut()as predicates against the actual recorded mapping and settings.^1.2.1for the corresponding fake assertion support.false.Why
The fake previously used assertion callbacks as builders for a second expected mapping or settings object. A name-only assertion could therefore fail when the recorded index contained fields that the assertion did not reproduce. This differs from Laravel fake assertions, where a callback inspects the operation that was actually dispatched and returns whether it matches.
Developer impact
Assertions can now focus on the operation:
A predicate can be added only when the recorded definition needs further inspection.
Dependency
Depends on DirectoryTree/OpenSearchAdapter#4. The adapter should be released as
v1.2.1before this package is released.Validation
vendor/bin/pintvendor/bin/pest— 96 tests, 205 assertions on themaster-based branchgit diff --check