Skip to content

Restart output if output settings are updated#1469

Open
BitRate27 wants to merge 1 commit into
DistroAV:masterfrom
BitRate27:websocketoutput
Open

Restart output if output settings are updated#1469
BitRate27 wants to merge 1 commit into
DistroAV:masterfrom
BitRate27:websocketoutput

Conversation

@BitRate27

Copy link
Copy Markdown
Contributor

This PR is to fix issue #1438 [Bug]: Output Name not updated when changed via Websocket

To fix the issue, the ndi_output_update callback was modified to:

  1. Check if the output is running, if so, stop it.
  2. Save the changes to the config depending on what output was updated.
  3. Restart the output if it was running.

This fixes the issue reported because the ndi_output_update callback is called when the settings are changed by the websocket API.

Here is a web page used to test this PR. The web page will allow the user to change the output settings via the websocket API:
obs_output_settings_modify.html

To test this PR:

  1. Download the html file.
  2. Open the html file in a web browser
  3. Launch OBS
  4. Select Connect on web page
  5. Select NDI Main Output or NDI Preview Output
  6. Change the name and/or group and select Apply
  7. See the NDI name change in NDI Studio Monitor
  8. Open DistroAV NDI Settings dialog
  9. Verify name and/or group changed

@BitRate27 BitRate27 added wip Output (Program/Preview) relate to NDI Output Progam or Preview labels Jun 20, 2026
@BitRate27

Copy link
Copy Markdown
Contributor Author

There are also issues with the StartOutput and StopOutput websocket commands not reflecting in the OutputSettings dialog. Will include fixes for that issue in this single PR. Original issue expanded to include this new found issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Output (Program/Preview) relate to NDI Output Progam or Preview wip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant