Restart output if output settings are updated#1469
Open
BitRate27 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
There are also issues with the StartOutput and StopOutput websocket commands not reflecting in the OutputSettings dialog. Will include fixes for that issue in this single PR. Original issue expanded to include this new found issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix issue #1438 [Bug]: Output Name not updated when changed via Websocket
To fix the issue, the ndi_output_update callback was modified to:
This fixes the issue reported because the ndi_output_update callback is called when the settings are changed by the websocket API.
Here is a web page used to test this PR. The web page will allow the user to change the output settings via the websocket API:
obs_output_settings_modify.html
To test this PR: