Skip to content

feat(i18n): add Portuguese (Portugal) translation (PT-pt)#177

Merged
Kombustor merged 1 commit into
DodoraApp:mainfrom
pdrgrl:feat/i18n-pt
Apr 28, 2026
Merged

feat(i18n): add Portuguese (Portugal) translation (PT-pt)#177
Kombustor merged 1 commit into
DodoraApp:mainfrom
pdrgrl:feat/i18n-pt

Conversation

@pdrgrl

@pdrgrl pdrgrl commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

What changed

Added Portuguese (Portugal) (pt) UI translation across all 7 namespaces:

  • common.json — generic labels (cancel, loading, retry…)
  • navigation.json — tab and screen names
  • media.json — media browsing, search, library UI
  • player.json — playback controls and error messages
  • profiles.json — profile management UI
  • setup.json — onboarding/setup wizard
  • settings.json — all settings screens (playback, subtitles, addons, Simkl, data, UI, about, remote control, developer)

Why

Portuguese (Portugal) is not yet available as a UI language. As a native European Portuguese speaker I wanted to contribute a complete, accurate translation using European Portuguese (not Brazilian).

Notes

  • Followed the translation guide in CONTRIBUTING.md
  • All JSON keys are identical to the en/ source of truth — only values were translated
  • The locale is auto-detected by the require.context scan in src/i18n/index.ts, so no config changes were needed
  • Used European Portuguese conventions throughout (e.g. "Definições" not "Configurações", "Eliminar" not "Deletar", "Ecrã" not "Tela")

How I tested

  • pnpm lint — passes
  • pnpm test — 5 suites were already failing on main before any changes
    (264/264 tests pass, the suite failures are pre-existing and unrelated to this PR)
  • Translation-only change (JSON values only, no code touched), so runtime behaviour
    is identical to the existing en/ and de/ locales which already work
  • Could not test on device — happy to update any strings if a maintainer spots
    issues during review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a complete Portuguese (pt) localization to the app’s i18n resources, expanding the set of auto-discovered locales under src/i18n/ without requiring runtime code changes.

Changes:

  • Added pt translations for all existing UI namespaces: common, navigation, media, player, profiles, setup, and settings.
  • Ensured translations preserve existing keys and interpolation tokens (e.g., {{name}}, {{count}}, {{minutes}}) consistent with the en/ source.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/i18n/pt/common.json Portuguese translations for shared/common UI labels.
src/i18n/pt/navigation.json Portuguese translations for tab/screen navigation labels.
src/i18n/pt/media.json Portuguese translations for browsing/search/library media UI.
src/i18n/pt/player.json Portuguese translations for player controls and playback errors.
src/i18n/pt/profiles.json Portuguese translations for profile management UI.
src/i18n/pt/setup.json Portuguese translations for onboarding/setup wizard steps.
src/i18n/pt/settings.json Portuguese translations across all settings sections (UI, playback, addons, Simkl, data, about, developer, remote control).

@Kombustor

Copy link
Copy Markdown
Contributor

Awesome, thank you! I'm curious about the 5 suites were already failing on main before any changes could you send me the logs of the failed tests, please?

@Kombustor Kombustor merged commit 134006f into DodoraApp:main Apr 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants