Fix reverting leaderboard and replace O(n^2) sorting with bounded top-K - #16
Merged
Merged
Conversation
- Return empty array when registeredPlayers.length == 0 or topN == 0 to prevent Solidity 0.8 checked arithmetic underflow - Replace full bubble sort with bounded insertion sort O(total * topN) - Define stable tie-breaking: equal scores ordered by registration order - Add getLeaderboardPage() for pagination support - Add tests for 0 players, 0 topN, 1 player, tied scores, large-N, oversized topN, and pagination edge cases Closes DogStark#8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registeredPlayers.length == 0ortopN == 0to prevent Solidity 0.8 checked arithmetic underflow ontotal - 1.totalScoreare ordered by registration order (earlier registration first).getLeaderboardPage(limit, offset): Pagination support for off-chain UIs that page through the full leaderboard.Closes #8
Test plan
getLeaderboard(10)returns empty array with zero registered players (no revert)getLeaderboard(0)returns empty array with registered playersgetLeaderboardPageacross multiple pagesnpx hardhat testto execute all testsGenerated with Claude Code