feat(player): configurable play/pause fade duration#1020
Open
JenteJan wants to merge 1 commit into
Open
Conversation
The play/pause volume fade was hardcoded to 175ms, which delays the actual mpv pause until the fade completes and makes toggling playback feel sluggish compared to native players like mpc/mpv. Expose the fade length as a 'Play/pause fade duration' setting (0-1000ms) shown beneath the existing fade toggle. A value of 0 (or any duration shorter than one fade step) now skips the fade entirely and hits mpv immediately for an instant, snappy response. Default stays at 175ms to preserve current behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds a "Play/pause fade duration" setting (0–1000 ms) under the existing Play/pause volume fade toggle in Settings → Player.
The play/pause volume fade is currently hardcoded to 175 ms. On pause this delays the actual
mpvpause until the fade finishes, which makes toggling playback feel less responsive than native players. Since the fade is a deliberate feature (nice for music), this exposes its length rather than removing it:mpvimmediately for an instant response.The fade-enabled code path is byte-for-byte unchanged; this only makes the duration configurable.
Issue Being Fixed
No existing issue — small, self-contained setting. Happy to open a discussion/issue first if you'd prefer per
CONTRIBUTING.md.Screenshots / Recordings
A new slider appears beneath the Play/pause volume fade toggle in Settings → Player (label: "Play/pause fade duration", shows
<value> ms). Screenshot to be added.Tested On
Checklist
Notes:
freezed/jsonfiles were updated by hand to mirror the existingcrossfadeDurationMsfield — runningbuild_runnerhere prunes unrelated stale generated files, so a targeted hand-edit keeps the diff clean. Analyzer-clean.