Repository navigation
Fix MSKIT_TEST005 on single-TFM test projects and MSKIT_PKG016 off GitHub - #6
Merged
Merged
Conversation
Net8/9/10 test projects with one TargetFramework must see IsNETxx and pass MSKIT_TEST005; a net6 one must still fail it; multi-TFM inner builds keep the props-phase values.
A single <TargetFramework> is set by the csproj body, after the props phase, so IsNETxx were empty there: MSKIT_TEST005 fired on net8-10 test projects and TestingPlatformDotnetTestSupport was never set. tfm.constants.targets clears and redefines them from TfmConstants' init.targets; the props-phase values stay for inner builds.
With the readme generator on, GitLab, self-hosted GitLab and an explicit MSKit_ReleasesUrl must fill PackageReleaseNotes and keep MSKIT_PKG016 quiet, incrementally too; an empty releases URL, an unknown host or MSKit_DefaultReleaseNotes=False still raise it.
PackageReleaseNotes defaulted only on GitHub, so MSKIT_PKG016 fired on GitLab and the other hosts even with the readme generator on. The generator now writes the releases URL it resolved beside the readme, and an empty PackageReleaseNotes takes it before the checks run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes before v0.2.0.
MSKIT_TEST005false positive — a test project with one<TargetFramework>(net8.0/9.0/10.0) got the error becauseIsNETxxwere evaluated in the props phase, before the csproj sets the framework (TfmConstants/init.props:3). The TfmConstants part now clears and redefines them in the targets phase (tfm.constants.targets); props-phase values stay for multi-targeted inner builds (Directory.Packages.propsconditions keep working). Also fixesTestingPlatformDotnetTestSupportnever being set on single-TFM net8/net9 test projects.MSKIT_PKG016off GitHub — withMSKit_PackageReadmeFromon, an emptyPackageReleaseNotesnow defaults to the releases page the readme generator resolves (GitLab, self-hosted GitLab, an explicitMSKit_ReleasesUrl). GitHub behaviour unchanged.Tests
sh tests/run.sh: 150 checks pass locally (Windows). Newtests/tfm-constants.sh(26 checks, fixturetests/fixtures/TfmConstants) and 16 new checks intests/package-readme.sh. Each fix toggled off once: 15 and 8 checks go red.