Repository navigation
Observer 1.0: Abstractions and Core - #2
Merged
Merged
Conversation
- MSBuildKit 0.1.1 under .toolkit, one version (1.0.0) for the repo - ci and release callers of the shared workflow, Dependabot - CONTRIBUTING, SECURITY, THIRD-PARTY-NOTICES, README, CHANGELOG
- Abstractions (netstandard2.0): MaskKind with Null, non-positional MaskTag with factories - Core (net8.0, net10.0): ValueKind, MaskStatus with Unrecognized, MaskFlags, MaskResult, PathOutcome, PathExplanation, UnknownMemberPolicy, NoContext, DataPath, NameMatch and Names - ObserverOptions with init properties, HashKeyId and WithBase64HashKey; ValuePolicy and MaskNulls - ValueMaskStrategy, MaskContext and MaskValueWriter, which validates number literals
- HMAC-SHA256 over the UTF-16 text, first 16 bytes in base64, after "<keyId>:" when HashKeyId is set; "" hashes to "" - strings hash their text, numbers and booleans their literal - tests compare a corpus with Microsoft.Extensions.Compliance.Redaction 10.10.0 and pin 0 B per warm call
- CommentPolicy (AllowList default, BlockList, MaskAll, Mask(tag), DropAll), CommentKind, CommentStyle, CommentContext, CommentRule and CommentRules; ObserverOptions.Comments - a kept comment of a masked owner is written masked unless Raw - docs/comments.md: policies, rules, ownership, the JSON examples
- ApiSurfaceTests snapshot each assembly with PublicApiGenerator - package readmes, so both packages pack without MSKIT_PKG findings
The toolchain guard that joins Abstractions in 1.1 ships as buildTransitive; a default project reference would exclude it.
- README, CHANGELOG 1.0.0 with the build requirement coming in 1.1 / 1.2 - docs/hashing.md (HmacRedactor format) next to docs/comments.md - DocSnippetTests compile and run the README, package readme and docs blocks; one API snapshot per assembly; CI packs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1, slice 2:
DragoAnt.Observer.Abstractions1.0 (netstandard2.0) andDragoAnt.Observer.Core1.0 (net8.0, net10.0). STJ.Observer 2.0 is rebuilt on it in DragoAnt/Extensions.System.Text.Json#10.ValueMaskStrategy+MaskContext+MaskValueWriter,ValuePolicy,MaskResult+MaskFlags,PathExplanation,DataPath,NameMatch/NamesMaskKind.Hash= MicrosoftHmacRedactoroutput (K15), tested against Microsoft.Extensions.Compliance.Redaction 10.10.0, 0 B warmCommentPolicy,CommentKind,CommentRule, masked-owner rulecomments.md,hashing.md), CHANGELOG 1.0.0Deviations from plan 01
DataPath/MaskContext/CommentContextconstructors and the path's push/pop are public but editor-hidden: the format bindings live in other repos, andInternalsVisibleToacross independently versioned repos breaks at runtime.WithBase64HashKeyis an extension, so it keeps the derived options type.NameCaseInsensitive(format-neutral).CommentPolicy.DropAlladded (the HTTP logger needs "never");Aftercomments are owned by the container.ValueIndex= position among the values handed to the strategy.Tests: 236 (118 per TFM).