Skip to content

[Snyk] Security upgrade eslint from 9.39.4 to 10.0.0 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snyk-io wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[Snyk] Security upgrade eslint from 9.39.4 to 10.0.0 #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/middleware/hono/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@modelcontextprotocol/eslint-config": "workspace:^",
"@eslint/js": "catalog:devTools",
"@typescript/native-preview": "catalog:devTools",
"eslint": "catalog:devTools",
"eslint": "10.0.0",

@kilo-code-bot kilo-code-bot Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: ESLint 10 bump diverges from the catalog and is not synced to the lockfile, so it will fail install/lint.

This PR pins eslint to a hard-coded exact 10.0.0 while every other package still uses catalog:devTools (^9.39.2). Problems:

  1. Lockfile not updated. Snyk's own PR description warns "Failed to update the pnpm-lock.yaml, please update manually before merging." The lockfile still resolves eslint@9.39.4 everywhere (grep of pnpm-lock.yaml shows no eslint@10). pnpm install in CI will be inconsistent / fail the lockfile check.
  2. Inconsistent across the monorepo. All other packages (client, server, core, etc.) keep catalog:devTools. Bumping only hono means two ESLint majors coexist in one workspace, which pnpm/eslint peer resolution will reject.
  3. ESLint 10 is a major breaking change (removes .eslintrc, requires flat config, Node >=20.19). The shared @modelcontextprotocol/eslint-config dep is still catalog:devTools (^9.39.2), so this package's eslint.config.mjs importing it would pull an incompatible peer. The whole monorepo must migrate to ESLint 10 together, not one leaf package.
  4. Exact pin instead of ^10.0.0. Even if intentional, an exact 10.0.0 pin breaks the catalog-driven single-version-of-truth strategy this repo uses.

Recommendation: revert this line; fix the brace-expansion vuln at the catalog level (or bump all packages + shared config + lockfile together), since the fix belongs in catalogs.devTools.eslint in pnpm-workspace.yaml.

Suggested change
"eslint": "10.0.0",
"eslint": "catalog:devTools",

"eslint-config-prettier": "catalog:devTools",
"eslint-plugin-n": "catalog:devTools",
"prettier": "catalog:devTools",
Expand Down
Loading