Skip to content

[Snyk] Security upgrade eslint from 9.39.4 to 10.0.0#74

Open
snyk-io[bot] wants to merge 1 commit into
mainfrom
snyk-fix-78fd4cc6b31d99d346b3c55fd290bcf1
Open

[Snyk] Security upgrade eslint from 9.39.4 to 10.0.0#74
snyk-io[bot] wants to merge 1 commit into
mainfrom
snyk-fix-78fd4cc6b31d99d346b3c55fd290bcf1

Conversation

@snyk-io

@snyk-io snyk-io Bot commented Jun 30, 2026

Copy link
Copy Markdown

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.

Snyk changed the following file(s):

  • packages/core/package.json
⚠️ Warning
Failed to update the pnpm-lock.yaml, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue
high severity Inefficient Algorithmic Complexity
SNYK-JS-BRACEEXPANSION-17706650

Breaking Change Risk

Merge Risk: High

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


This change is Reviewable

@snyk-io

snyk-io Bot commented Jun 30, 2026

Copy link
Copy Markdown
Author

Merge Risk: High

This major upgrade to ESLint v10 introduces significant breaking changes, most notably the complete removal of the legacy .eslintrc configuration system. All projects must migrate to the eslint.config.js (flat config) format.

Key Breaking Changes:

  • Removal of .eslintrc: Support for .eslintrc.* and .eslintignore files has been completely removed. [1, 2, 7] You must migrate to a eslint.config.js file. [5, 10] Related CLI flags like --no-eslintrc and --ignore-path are also removed. [1]
  • Node.js Version Requirement: Support for Node.js versions older than v20.19.0 has been dropped. [1, 2] You must ensure your environment is running a compatible Node.js version. [5]
  • New Config Lookup: The configuration file is now located by searching from the directory of each linted file, which is a change from the previous behavior of searching from the current working directory. [1, 6]
  • eslint-env Comments: Using /* eslint-env */ comments will now cause linting errors. [2, 5]

Recommendation:
This upgrade requires a mandatory migration of your ESLint configuration from the legacy .eslintrc format to the modern eslint.config.js flat config format. Follow the official Configuration Migration Guide before upgrading. [2, 10]

Source: ESLint v10.0.0 Release Notes, Migration Guide

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

@snyk-io

snyk-io Bot commented Jun 30, 2026

Copy link
Copy Markdown
Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-io

snyk-io Bot commented Jun 30, 2026

Copy link
Copy Markdown
Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

"@modelcontextprotocol/vitest-config": "workspace:^",
"@typescript/native-preview": "catalog:devTools",
"eslint": "catalog:devTools",
"eslint": "10.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Lockfile is stale — pnpm-lock.yaml still records eslint@9.39.4 for this package (specifier catalog:devTools). The PR body itself warns: "Failed to update the pnpm-lock.yaml, please update manually before merging." Until the lockfile is updated, this change installs nothing different.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

"@modelcontextprotocol/vitest-config": "workspace:^",
"@typescript/native-preview": "catalog:devTools",
"eslint": "catalog:devTools",
"eslint": "10.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Incomplete workspace-wide fix — the devTools catalog in pnpm-workspace.yaml still defines eslint: ^9.39.2, and every other package (including the shared @modelcontextprotocol/eslint-config) still uses catalog:devTools. Only packages/core bypasses the catalog, so the vulnerability is not fixed for the rest of the workspace and packages/core now runs eslint@10.0.0 against a shared config resolved for eslint@9.x.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

"@modelcontextprotocol/vitest-config": "workspace:^",
"@typescript/native-preview": "catalog:devTools",
"eslint": "catalog:devTools",
"eslint": "10.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Potential peer-dependency breakage — the lockfile shows typescript-eslint resolved to 8.57.2(eslint@9.39.4) and eslint-plugin-n to 17.24.0(eslint@9.39.4), indicating these plugins are peer-matched against eslint 9.x. Moving eslint to 10.0.0 without upgrading typescript-eslint and related plugins will likely cause lint failures.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 3 Warnings | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/core/package.json 54 Lockfile is stale — pnpm-lock.yaml still records eslint@9.39.4 for this package (specifier catalog:devTools). The PR body itself warns: "Failed to update the pnpm-lock.yaml, please update manually before merging." Until the lockfile is updated, this change installs nothing different.
packages/core/package.json 54 Incomplete workspace-wide fix — the devTools catalog in pnpm-workspace.yaml still defines eslint: ^9.39.2, and every other package (including the shared @modelcontextprotocol/eslint-config) still uses catalog:devTools. Only packages/core bypasses the catalog, so the vulnerability is not fixed for the rest of the workspace and packages/core now runs eslint@10.0.0 against a shared config resolved for eslint@9.x.
packages/core/package.json 54 Potential peer-dependency breakage — the lockfile shows typescript-eslint resolved to 8.57.2(eslint@9.39.4) and eslint-plugin-n to 17.24.0(eslint@9.39.4), indicating these plugins are peer-matched against eslint 9.x. Moving eslint to 10.0.0 without upgrading typescript-eslint and related plugins will likely cause lint failures.
Files Reviewed (1 file)
  • packages/core/package.json - 3 warnings

Fix these issues in Kilo Cloud


Reviewed by step-3.7-flash-20260528 · Input: 58.9K · Output: 13K · Cached: 607.9K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants