지도 축제탭 별도 색상 지정#522
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Festival color and updates the PartnershipToggleItem component to apply this color based on a string comparison with the label. The reviewer recommends refactoring this logic to pass the color or filter type as a parameter, which would improve component reusability and prevent potential bugs caused by hardcoded string checks.
Comment on lines
+89
to
+94
| if (selected && (label == stringResource(R.string.partnership_filter_festival))) | ||
| Festival | ||
| else if (selected) | ||
| Primary | ||
| else | ||
| Color.Transparent |
Contributor
There was a problem hiding this comment.
문자열 비교(label == stringResource(...))를 통해 UI 색상을 결정하는 방식은 유지보수와 정확성 측면에서 취약합니다.
- 잠재적 버그: '내 제휴' 탭에서 사용자의 학과명이 '축제'와 일치할 경우, 의도치 않게 축제 탭의 색상이 적용될 수 있습니다.
- 재사용성 저해:
PartnershipToggleItem이라는 공통 컴포넌트가 특정 비즈니스 로직(축제)에 의존하게 됩니다.
PartnershipToggleItem이 UI 표현에만 집중할 수 있도록, 선택 시 적용할 색상(selectedColor)을 파라미터로 직접 전달받거나 FilterType을 전달받아 처리하도록 리팩토링하는 것을 권장합니다. 호출부인 PartnershipFilterToggle에서 타입에 따라 적절한 색상을 결정하여 넘겨주는 방식이 더 안전합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
지도 축제 탭에 별도 색상 지정했습니다
Describe your changes
Issue
To reviewers