#2479 - Fix header/footer section parsing when &L is not first - #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2479
Problem
Header/footer sections were lost when not stored in Left, Center, Right order.
ExcelHeaderFooterText's constructor took the first section code from the first twocharacters, then scanned for further codes — but only recognized
&Cand&R, never&L. A&Lappearing anywhere other than position 0 was not treated as a new section.Its content was swallowed by the preceding section, then discarded when that section was
normalized, taking any
&Gpicture placeholder with it. The picture survived in the VMLcollection, so
Pictures.Countwas unchanged, but nothing referenced it and it stoppedrendering.
Excel writes sections in creation order, so ordinary Excel-authored files were affected.
Fix
Three changes in the constructor's parse loop:
&Ladded as a section delimiter (the actual bug)pos = startPos - 1— the loop'spos++previously skipped a character, missing a code following an empty sectiontext.Length - 1— a code in the final two characters was never seenTests
HeaderFooterSectionOrderTestscovers ordering permutations and both boundary cases