Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2488
This bug is arguably a variant of #450 AKA (s224) as it pertains to Epplus reading Empty border elements in the dxf record
e.g:
Adding "None" to a dxf border-style did not write any nodes to the .xml
This caused Conditional-Formattings to be unable to "format" cell-border styles as they did not contain the correct node.
The issue at its core was that we considered the setting of the style "None" to be equivalent to "null" for the "HasValue" variable.
I applied a patch via checking if the nodes for individual borders exist via
AtLeastOneBorderExists()But we should consider if "HasValue" should be true for "none" values. It appears to be a re-occuring problem in multiple places in Epplus where Excel Considers an empty Node to be a Default Value but we consider and Empty Node to be "HasValue == False"