Copilot/fix failing GitHub actions job again#7
Closed
EPW80 wants to merge 4 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the backend API service’s non-production file-upload path to avoid a circular-import initialization problem by lazily loading secureStorageService only when needed.
Changes:
- Removed the eager
secureStorageServiceimport fromapiService.js. - Added a cached dynamic import (
import("./secureStorageService.js")) insidehandleFileUpload()to defer module initialization until runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
476
to
480
| if (!secureStorageService.initialized) { | ||
| await secureStorageService.initialize(); | ||
| } | ||
|
|
||
| // Use the correct method name that exists in secureStorageService | ||
| return secureStorageService.uploadToIPFS(file); |
Comment on lines
+470
to
+472
| if (!secureStorageServiceModulePromise) { | ||
| secureStorageServiceModulePromise = import("./secureStorageService.js"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.