Skip to content

CI: make “Lint (non-blocking)” run client lint as report-only#8

Merged
EPW80 merged 2 commits into
mainfrom
copilot/fix-lint-non-blocking-job
Jun 13, 2026
Merged

CI: make “Lint (non-blocking)” run client lint as report-only#8
EPW80 merged 2 commits into
mainfrom
copilot/fix-lint-non-blocking-job

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The non-blocking lint job was failing during ESLint config resolution instead of reporting lint results, due to running root lint with dependencies installed via root --ignore-scripts. This updates the job to execute lint in the client context and keep failures explicitly non-blocking.

  • Workflow scope correction

    • Install dependencies for the frontend lint target directly:
      • npm install --prefix client --ignore-scripts
    • Run lint from the same target:
      • npm run lint --prefix client
  • Non-blocking behavior at lint step

    • Keep lint diagnostics visible while preventing the step from failing the job:
      • continue-on-error: true on the lint step
- run: npm install --prefix client --ignore-scripts
- name: Client lint (report-only)
  continue-on-error: true
  run: npm run lint --prefix client

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
healthmint Ready Ready Preview, Comment Jun 13, 2026 3:58am

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Lint (non-blocking) CI: make “Lint (non-blocking)” run client lint as report-only Jun 13, 2026
Copilot finished work on behalf of EPW80 June 13, 2026 03:57
Copilot AI requested a review from EPW80 June 13, 2026 03:57
@EPW80 EPW80 marked this pull request as ready for review June 13, 2026 04:13
Copilot AI review requested due to automatic review settings June 13, 2026 04:13
@EPW80 EPW80 merged commit f9fda2b into main Jun 13, 2026
4 of 5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the non-blocking CI lint job to lint the frontend (client) in its own dependency context, so ESLint can resolve the correct config/plugins and report results without blocking the workflow.

Changes:

  • Install dependencies for the client workspace in the lint job (npm install --prefix client ...).
  • Run client lint explicitly (npm run lint --prefix client).
  • Make the lint step explicitly report-only via continue-on-error: true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
node-version: 18
- run: npm install --ignore-scripts
- run: npm run lint
- run: npm install --prefix client --ignore-scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants