Update MOM_input parameters for tx2_3v2/tx2_3v3 grids#326
Update MOM_input parameters for tx2_3v2/tx2_3v3 grids#326alperaltuntas merged 5 commits intoESCOMP:mainfrom
Conversation
|
@alperaltuntas and @mnlevy1981 |
|
The |
alperaltuntas
left a comment
There was a problem hiding this comment.
The KH_BG_2D file has NaN values on 30 ocean cells of the tx2_3v2 grid (I haven't checked the v3 file). That's causing the DEBUG tests to fail. While we should fix those cells in the input file, that alone may not be enough since we take averages on q-points (where there may be adjacent NaN land points). So I think two things should happen:
- Fix the file. The 30 cells should be corrected.
- Set land point values to zero in the code.
@gustavo-marques could you address (1)? I can then take care of (2) if it turns out to be needed after (1).
See a diagnostic script:
/glade/work/altuntas/cesm.sandboxes/cesm3_0_beta08/components/mom/check_kh_bg_2d_nans.py
Actually, (2) is already in the code. So, I think all we need is (1). |
|
I've updated both files, and I kept the same name, so we do not need to update MOM_input: |
|
@mnlevy1981 @gustavo-marques Can we override already imported files? |
|
@alperaltuntas, Mike just told me we cannot. I am recreating these files with today's date. |
|
I've created new files using today's date, and updated MOM_input and input_data_list. Here are the new files: |
These files have been imported as well |
|
@gustavo-marques The tx3_v2 tests are now passing, but I'll also run v3 tests before merging. |
Updates parameter values in MOM_input.yaml and MOM_input.json for the tx2_3v2 and tx2_3v3 grids. Changes include:
New parameters:
Tuning changes:
Removed: MLE_DENSITY_DIFF (reverts to default)
USE_CR and CR_FILE are now only set when ATM = cam
Addresses #307