Conversation
ERuban
force-pushed
the
extract_crud_permission_checker
branch
from
September 17, 2026 19:36
d3bd8c2 to
c5243fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 5.0.10,
AssociationConfiguratorchecks the target controller'sCrud::setEntityPermission()andActions::setPermission()before rendering the link to the related entity. That logic is private, so third-party configurators that render links or embedded blocks pointing to another CRUD controller can't reuse it and end up copying it or duplicating permission names on the field.This PR extracts it into a public service,
CrudPermissionCheckerInterface::isGranted($context, $crudControllerFqcn, $action, ?$entityDto), used byAssociationConfiguratoritself and available to any custom configurator. The per-request cache and itskernel.resettag move along with it. No behaviour change forAssociationField.Also adds a section to
doc/security.rstand a functional test onSecuredAppfor the association-link permission check (it had only unit coverage before).