Skip to content

fix: UnmarshalJSON on Event objects for Go 1.27 - #284

Merged
Justin Hammond (Justintime50) merged 1 commit into
masterfrom
fix_unmarshal_event
Sep 9, 2026
Merged

Justin Hammond (Justintime50) merged 1 commit into
masterfrom
fix_unmarshal_event

Conversation

@Justintime50

@Justintime50 Justin Hammond (Justintime50) commented Sep 9, 2026

Copy link
Copy Markdown
Member

Description

UnmarshalJSON on Go 1.27 would recurse, this fixes it by swapping how the pointer is used.

Closes #283

Testing

Added new test cases to ensure this works.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@Justintime50
Justin Hammond (Justintime50) merged commit 969357d into master Sep 9, 2026
17 checks passed
@Justintime50
Justin Hammond (Justintime50) deleted the fix_unmarshal_event branch September 9, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: (e *Event) UnmarshalJSON() causes a stack overflow in go 1.27 with json/v2

2 participants