SDL3: Make it the default, further Emscripten & Android fixes#3543
Draft
Ghabry wants to merge 11 commits intoEasyRPG:masterfrom
Draft
SDL3: Make it the default, further Emscripten & Android fixes#3543Ghabry wants to merge 11 commits intoEasyRPG:masterfrom
Ghabry wants to merge 11 commits intoEasyRPG:masterfrom
Conversation
Bump required version to 3.4.0. That version added some features which will be required for the GPU renderer.
Guess they are not required anymore?
…iting it This appears to be a regression (reported as SDL#15502)
Otherwise the Window is a blurry mess on 4k displays, at least on Linux
…wn which corrupts memory This can happen when the system graphic is invalid, as ResetGameObjects will init the data structures again Another issue with our fragile shutdown system :(
…s unncessary There also seems to be a codegen bug. Invoking of some constructors on shutdown results in "function signature mismatch". This prevents the global constructors to be called at the end. Manually invoke our onExit handler instead. Removed the extern from main as this emitted a warning Fix EasyRPG#3464
github-actions
Bot
added
Building
Emscripten
Member
Author
|
guess for the github runners I have to set them to SDL2. Looking at repology the first Debian/Ubuntu with a new enough SDL3 (3.4) are Debian 14 and Ubuntu 26.04 😅 |
carstene1ns
reviewed
May 9, 2026
| cfg.renderer.Lock("SDL3 (Software, Emscripten)"); | ||
| #elif defined(__wii__) | ||
| cfg.renderer.Lock("SDL2 (Software, Wii)"); | ||
| cfg.renderer.Lock("SDL3 (Software, Wii)"); |
Member
There was a problem hiding this comment.
I guess the Wii (U) stuff here is not needed the next 10 years^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as the Android fixes are missing cough - working on it.
Though already good enough for testing Emscripten and other platforms if anything breaks.