Skip to content

add check for taxlot.legal_label before split #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paigewilliams merged 1 commit into from
Aug 27, 2026
Merged

add check for taxlot.legal_label before split #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions landmapper/app/reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,11 @@ def get_aggregate_property_data(property, taxlots):
max_elevation.append(taxlot.max_elevation)
# HACK: the first value in the legal description was accidentally converted
# to a float before stringification. This removes the extra decimal data
legal_label = taxlot.legal_label
legal_label = ''.join(legal_label.split('.0'))

@rhodges rhodges Aug 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the line that sent us 27 error emails in the last 7 days? Heck yes, squash that 馃悰 !

legal.append("%s" %
(legal_label))
if taxlot.legal_label is not None:
legal_label = taxlot.legal_label
legal_label = ''.join(legal_label.split('.0'))

@rhodges rhodges Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall the type of taxlot.legal_label. From this code, I assume it's str, but if None has been coming in, could it also be something else? Perhaps an array? Is it overkill to wrap this is a try/except block? ...I can see why you prefer strongly-typed languages 馃槃

legal.append("%s" %
(legal_label))
agency.append(taxlot.agency)
odf_fpd.append(taxlot.odf_fpd)
name.append(taxlot.name)
Expand Down
Loading