Merge upstream 1.330

.github/PULL_REQUEST_TEMPLATE.md

@@ -8,7 +8,7 @@
 - [ ] Add JavaDocs and other comments explaining the behavior. 
 - [ ] When adding or updating methods that fetch entities, add `@link` JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest . 
 - [ ] Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See [CONTRIBUTING.md](CONTRIBUTING.md) for details.
-- [ ] Run `mvn -D enable-ci clean install site` locally. If this command doesn't succeed, your change will not pass CI.
+- [ ] Run `mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"` locally. If this command doesn't succeed, your change will not pass CI.
 - [ ] Push your changes to a branch other than `main`. You will create your PR from that branch.
 
 # When creating a PR: 

.github/workflows/codeql-analysis.yml

@@ -42,13 +42,13 @@ jobs:
 
     steps:
     - name: Set up JDK
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@v5
       with:
         distribution: 'temurin'
         java-version: 17
 
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/create_release_tag_and_pr.yml

@@ -10,48 +10,50 @@ jobs:
   create_release_tag:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-depth: 0
 
       - name: Set up Maven Central Repository
-        uses: actions/setup-java@v4
+        uses: actions/setup-java@v5
         with:
           java-version: '17'
           distribution: 'temurin'
           cache: 'maven'
 
-      - name: Reset staging/main
+      - name: Reset staging
         id: staging
         run: |
-          git checkout -B staging/main
-          git push --set-upstream -f origin staging/main
+          git checkout -B staging/$GITHUB_REF_NAME
+          git push --set-upstream -f origin staging/$GITHUB_REF_NAME
+        env:
+          GITHUB_REF_NAME: ${{ github.ref_name }}
 
       - name: Set Release Version
         id: release
         run: |
           mvn -B versions:set versions:commit -DremoveSnapshot 
           echo "version=$(mvn -B help:evaluate -Dexpression=project.version -q -DforceStdout)" >> $GITHUB_OUTPUT
 
-      - uses: stefanzweifel/git-auto-commit-action@v5
+      - uses: stefanzweifel/git-auto-commit-action@v6
         with:
           commit_message: "Prepare release (${{ github.actor }}): github-api-${{ steps.release.outputs.version }}" 
           tagging_message: 'github-api-${{ steps.release.outputs.version }}'
-          branch: staging/main
+          branch: staging/${{ github.ref_name }}
 
       - name: Increment Snapshot Version
         run: |
           mvn versions:set versions:commit -DnextSnapshot 
 
-      - uses: stefanzweifel/git-auto-commit-action@v5
+      - uses: stefanzweifel/git-auto-commit-action@v6
         with:
           commit_message: "Prepare for next development iteration"
-          branch: staging/main
+          branch: staging/${{ github.ref_name }}
 
-      - name: pull-request to main
+      - name: Create pull-request
         uses: repo-sync/pull-request@v2
         with:
           pr_title: "Prepare release (${{ github.actor }}): github-api-${{ steps.release.outputs.version }}"
-          source_branch: "staging/main"
-          destination_branch: "main"
+          source_branch: "staging/${{ github.ref_name }}"
+          destination_branch: "${{ github.ref_name }}"
           github_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/maven-build.yml

@@ -25,9 +25,9 @@ jobs:
     strategy:
       fail-fast: true
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Set up JDK
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@v5
       with:
         java-version: 17
         distribution: 'temurin'
@@ -47,9 +47,9 @@ jobs:
     strategy:
       fail-fast: false
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Set up JDK
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@v5
       with:
         java-version: 17
         distribution: 'temurin'
@@ -71,9 +71,9 @@ jobs:
         os: [ ubuntu, windows ]
         java: [ 17, 21 ]
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Set up JDK
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@v5
       with:
         java-version: ${{ matrix.java }}
         distribution: 'temurin'
@@ -98,16 +98,17 @@ jobs:
         retention-days: 3
   codecov-upload:
     name: codecov-upload (Upload to codecov.io)
+    if: github.repository == 'hub4j/github-api'
     needs: test
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
-    - uses: actions/download-artifact@v4
+    - uses: actions/checkout@v5
+    - uses: actions/download-artifact@v5
       with:
         name: maven-test-target-directory
         path: target
     - name: Codecov Report
-      uses: codecov/codecov-action@v5.1.2
+      uses: codecov/codecov-action@v5.5.0
       with:
         # Codecov token from https://app.codecov.io/gh/hub4j/github-api/settings
         token: ${{ secrets.CODECOV_TOKEN }}
@@ -138,13 +139,13 @@ jobs:
     needs: build
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
-    - uses: actions/download-artifact@v4
+    - uses: actions/checkout@v5
+    - uses: actions/download-artifact@v5
       with:
         name: maven-target-directory
         path: target
     - name: Set up JDK
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@v5
       with:
         java-version: 11
         distribution: 'temurin'

.github/workflows/publish_release_branch.yml

@@ -12,9 +12,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Maven Central Repository
-        uses: actions/setup-java@v4
+        uses: actions/setup-java@v5
         with:
           java-version: '17'
           distribution: 'temurin'
@@ -35,9 +35,9 @@ jobs:
     runs-on: ubuntu-latest
     needs: build
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Maven Central Repository
-        uses: actions/setup-java@v4
+        uses: actions/setup-java@v5
         with:
           java-version: '17'
           distribution: 'temurin'
@@ -55,13 +55,13 @@ jobs:
           MAVEN_USERNAME: ${{ secrets.OSSRH_TOKEN_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN_PASSWORD }}
           MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSPHRASE }}
-
+  
   publish_gh_pages:
     runs-on: ubuntu-latest
     needs: build
     if:  ${{ github.ref == 'refs/heads/release/v2.x' }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-depth: 0  
 
@@ -70,7 +70,7 @@ jobs:
         run: |
           echo "version=$(mvn -B help:evaluate -Dexpression=project.version -q -DforceStdout)" >> $GITHUB_OUTPUT
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v5
         with:
           name: maven-release-target-directory
           path: target
@@ -82,7 +82,7 @@ jobs:
           cp -r ./target/site/* ./
 
       - name: Publish GH Pages
-        uses: stefanzweifel/git-auto-commit-action@v5
+        uses: stefanzweifel/git-auto-commit-action@v6
         with:
           commit_message: "Release (${{ github.actor }}): v${{ steps.release.outputs.version }}" 
           branch: gh-pages

.gitignore

@@ -6,6 +6,7 @@ target
 .classpath
 .project
 .settings/
+.metadata/
 .DS_Store
 
 dependency-reduced-pom.xml

README.md

@@ -35,4 +35,4 @@ Now the new version is available to be used in main project dependencies.
 [![codecov](https://codecov.io/gh/hub4j/github-api/branch/main/graph/badge.svg?token=j1jQqydZLJ)](https://codecov.io/gh/hub4j/github-api)
 
 
-See https://github-api.kohsuke.org/ for more details
+See https://hub4j.github.io/github-api/ for more details

pom.xml

@@ -2,7 +2,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>org.kohsuke</groupId>
   <artifactId>github-api</artifactId>
-  <version>1.327-ecwid-12</version>
+  <version>1.330-ecwid-1</version>
   <name>GitHub API for Java</name>
   <url>https://github-api.kohsuke.org/</url>
   <description>GitHub API for Java</description>
@@ -18,12 +18,12 @@
     <snapshotRepository>
       <id>sonatype-nexus-snapshots</id>
       <name>Sonatype Nexus Snapshots</name>
-      <url>https://s01.oss.sonatype.org/content/repositories/snapshots/</url>
+      <url>${nexus.serverUrl}/content/repositories/snapshots/</url>
     </snapshotRepository>
     <repository>
       <id>sonatype-nexus-staging</id>
       <name>Nexus Release Repository</name>
-      <url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
+      <url>${nexus.serverUrl}/service/local/staging/deploy/maven2/</url>
     </repository>
     <site>
       <id>github-pages</id>
@@ -49,6 +49,9 @@
 
     <jacoco.surefire.argLine />
     <surefire.argLine />
+
+    <!-- This project was registered before 2021, so it uses the old server. -->
+    <nexus.serverUrl>https://ossrh-staging-api.central.sonatype.com</nexus.serverUrl>
   </properties>
 
   <build>
@@ -237,7 +240,7 @@
           <extensions>true</extensions>
           <configuration>
             <serverId>sonatype-nexus-staging</serverId>
-            <nexusUrl>https://oss.sonatype.org/</nexusUrl>
+            <nexusUrl>${nexus.serverUrl}/</nexusUrl>
             <autoReleaseAfterClose>true</autoReleaseAfterClose>
           </configuration>
         </plugin>
@@ -475,7 +478,7 @@
       <dependency>
         <groupId>com.fasterxml.jackson</groupId>
         <artifactId>jackson-bom</artifactId>
-        <version>2.18.2</version>
+        <version>2.20.0</version>
         <scope>import</scope>
         <type>pom</type>
       </dependency>
@@ -486,7 +489,7 @@
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>3.17.0</version>
+      <version>3.18.0</version>
     </dependency>
     <dependency>
       <groupId>com.tngtech.archunit</groupId>

src/main/java/org/kohsuke/github/GHBranch.java

@@ -111,11 +111,18 @@ public GHBranchProtection getProtection() throws IOException {
         return root().createRequest().setRawUrlPath(protection_url).fetch(GHBranchProtection.class);
     }
 
-	public PagedIterable<GHRule> getRules() throws IOException {
-		return root().createRequest()
-				.withUrlPath(owner.getApiTailUrl("rules/branches/" + name))
-				.toIterable(GHRule[].class, GHRule::wrap);
-	}
+    /**
+     * Lists rules configured for this branch.
+     *
+     * @return branch rules
+     * @throws IOException
+     *             if an I/O error occurs
+     */
+    public PagedIterable<GHRule> getRules() throws IOException {
+        return root().createRequest()
+                .withUrlPath(owner.getApiTailUrl("rules/branches/" + name))
+                .toIterable(GHRule[].class, GHRule::wrap);
+    }
 
     /**
      * Gets sha 1.

src/main/java/org/kohsuke/github/GHCommit.java

@@ -350,40 +350,43 @@ public GHRepository getOwner() {
         return owner;
     }
 
-	/**
-	 * Gets commit verification.
-	 * @return
-	 */
-	public GHVerification getVerification() {
-		return commit.getVerification();
-	}
-
-	/**
-	 * Gets commit author.
-	 * @return
-	 */
-	public GitUser getCommitAuthor() {
-		return commit.getAuthor();
-	}
-
-	/**
-	 * Gets commit committer.
-	 * @return
-	 */
-	public GitUser getCommitCommitter() {
-		return commit.getCommitter();
-	}
-
-	/**
-	 * Gets message.
-	 *
-	 * @return the commit message
-	 * @throws IOException
-	 *             the io exception
-	 */
-	public String getMessage() throws IOException {
-		return getCommitShortInfo().getMessage();
-	}
+    /**
+     * Gets commit verification.
+     *
+     * @return the commit verification
+     */
+    public GHVerification getVerification() {
+        return commit.getVerification();
+    }
+
+    /**
+     * Gets commit author.
+     *
+     * @return the commit author
+     */
+    public GitUser getCommitAuthor() {
+        return commit.getAuthor();
+    }
+
+    /**
+     * Gets commit committer.
+     *
+     * @return the commit committer
+     */
+    public GitUser getCommitCommitter() {
+        return commit.getCommitter();
+    }
+
+    /**
+     * Gets message.
+     *
+     * @return the commit message
+     * @throws IOException
+     *             the io exception
+     */
+    public String getMessage() throws IOException {
+        return getCommitShortInfo().getMessage();
+    }
     /**
      * Gets lines changed.
      *