Skip to content

test(cli): cover prerouter defaults at engine dispatch - #143

Merged
shuk777 merged 1 commit into
Edge0-AI:mainfrom
agourakis82:test/cli-routing-contract-local
Oct 19, 2026
Merged

shuk777 merged 1 commit into
Edge0-AI:mainfrom
agourakis82:test/cli-routing-contract-local

Conversation

@agourakis82

Copy link
Copy Markdown
Contributor

What & why

Add CLI dispatch coverage for the intentional prerouter defaults. The registry helper is already tested, but these cases also check the arguments that actually reach AutoEngine.from_pretrained through demo, chat, and serve.

The 12 cases cover both model tiers with and without --no-prerouter. Only the 8B demo disables the prerouter by default; chat, serve, and the 35B demo preserve their normal defaults. No runtime behavior changes.

Area

  • Python framework (python/)

How was it tested?

On Apple Silicon/macOS, from python/:

python -m pytest -q -rs tests/test_cli_flags.py tests/test_registry.py tests/test_server.py tests/test_tool_calls.py tests/test_repo_hygiene.py

106 passed, no skips, with Flask installed in the local test environment. Dependency pins are unchanged.

A process-local negative control replaced demo_kwargs with a passthrough: the new default 8B demo case failed as expected, while the other 11 new cases passed. No source mutation was retained.

The new tests stop at a mocked engine constructor. They do not load weights or validate numerical inference. The complete pytest -m 'not slow' suite was not run locally; the command above is the full extent of this candidate's local test validation.

Checklist

  • pytest -m 'not slow' passes locally (full suite not run)
  • Repo hygiene passes
  • Added regression coverage for existing behavior
  • Dependency pins unchanged
  • No user-facing behavior or documentation changes needed

AI assistance was used for implementation and review, including a local Edge0/MLX review. The changes and test results were checked before submission.

@shuk777 shuk777 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pr!

@shuk777
shuk777 merged commit 8c2d422 into Edge0-AI:main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants