Repository navigation
test(cli): cover prerouter defaults at engine dispatch - #143
Merged
shuk777 merged 1 commit intoOct 19, 2026
Merged
Conversation
shuk777
approved these changes
Oct 19, 2026
shuk777
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the pr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Add CLI dispatch coverage for the intentional prerouter defaults. The registry helper is already tested, but these cases also check the arguments that actually reach
AutoEngine.from_pretrainedthroughdemo,chat, andserve.The 12 cases cover both model tiers with and without
--no-prerouter. Only the 8B demo disables the prerouter by default; chat, serve, and the 35B demo preserve their normal defaults. No runtime behavior changes.Area
python/)How was it tested?
On Apple Silicon/macOS, from
python/:106 passed, no skips, with Flask installed in the local test environment. Dependency pins are unchanged.
A process-local negative control replaced
demo_kwargswith a passthrough: the new default 8B demo case failed as expected, while the other 11 new cases passed. No source mutation was retained.The new tests stop at a mocked engine constructor. They do not load weights or validate numerical inference. The complete
pytest -m 'not slow'suite was not run locally; the command above is the full extent of this candidate's local test validation.Checklist
pytest -m 'not slow'passes locally (full suite not run)AI assistance was used for implementation and review, including a local Edge0/MLX review. The changes and test results were checked before submission.