Map ROBINHOOD_INIT in splitEnvJson - #6234
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
peachbits
approved these changes
Oct 1, 2026
Robinhood Chain landed a day before the env.json split, so CURRENCY_INIT_MAP never got its entry. The migration dropped ROBINHOOD_INIT without a warning and wrote a config.json with no corePlugins.robinhood. coreInit treats an absent plugin as disabled, so the migrated app had no Robinhood Chain: no wallet creation and no split target from other EVM wallets.
j0ntz
force-pushed
the
jon/hood-support-splitting
branch
from
October 1, 2026 22:43
f672da3 to
a62bfb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Splitting an EVM wallet into a Robinhood Chain wallet already works on develop: the accountbased plugin reports every EVM chain as a split target, and Robinhood Chain is not flagged
isSplittingDisabled. Tested on the iOS simulator from two EVM sources (Ethereum and Polygon) into Robinhood Chain, and from Robinhood Chain into Optimism. The split wallet has the same receive address as its source.The one defect found is in the legacy config migration. Robinhood Chain landed a day before the
env.jsonsplit, andCURRENCY_INIT_MAPinscripts/splitEnvJson.tsnever got aROBINHOOD_INITentry. Thesplit-env-jsonscript dropped that field without a warning and wrote aconfig.jsonwith nocorePlugins.robinhood.coreInittreats an absent plugin as disabled. An app built from a migrated config had no Robinhood Chain at all, split target included.This PR adds the missing map entry. Run against the same legacy
env.json, develop writes 52corePluginswithrobinhoodabsent, and this branch writes 53 withrobinhood: true.The first commit replaces the deprecated
asMapcleaner in the same file withasObject.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
f672da3Map ROBINHOOD_INIT in splitEnvJson
2026-10-01
1. split target robinhood
2. split confirm
3. split 404 alert
4. robinhood wallet present
5. reverse split list
6. reverse split done
7. robinhood receive address
8. eth receive address
9. polygon split target robinhood
10. polygon split returned
11. robinhood wallets after second split