feat: add launch video animation scenes#134
Merged
Merged
Conversation
Storybook-based animation components for the Desktest CLI launch video, with a Playwright headless recording pipeline that captures at 1920x1080 and converts to H.264 MP4. Scenes: Title → Run → Loop → Debug → Codify → QA → Orchestration → Closing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
There was a problem hiding this comment.
2 issues found across 28 files
Confidence score: 4/5
- This PR looks safe to merge with minimal risk: the reported issues are mostly hygiene/config consistency rather than likely runtime regressions.
- The most severe item is in
animations/.gitignore(6/10, high confidence): not ignoringrecordings/*.mp4can lead to large binary artifacts (likedesktest-launch.mp4) being committed, which can bloat repo history and complicate maintenance. - In
animations/package.json, the Storybook port mismatch (6006vs documented6020) is a low-to-moderate coordination issue and may cause test-plan confusion, but it is unlikely to break production behavior. - Pay close attention to
animations/.gitignoreandanimations/package.json- prevent future MP4 commits and align the Storybook port with the documented test plan.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="animations/package.json">
<violation number="1" location="animations/package.json:5">
P2: The storybook port (`6006`) doesn't match the port documented in the PR test plan (`6020`). Update the script to use `-p 6020` if that's the intended port, or update the PR description.</violation>
</file>
<file name="animations/.gitignore">
<violation number="1" location="animations/.gitignore:2">
P2: Missing `recordings/*.mp4` from `.gitignore`. The recording pipeline outputs MP4 files, and `desktest-launch.mp4` is already tracked in the repo. Large binary video files should not be committed to git as they permanently bloat repository history.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
- Update storybook port from 6006 to 6020 in package.json - Add recordings/*.mp4 to .gitignore and untrack committed mp4 file Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cd animations && bun install && bun run storybookto view individual scenes at localhost:6020node animations/scripts/record-animation.mjsto record the full ~78s launch videoanimations/recordings/desktest-launch.mp4plays correctly with all 8 scenes🤖 Generated with Claude Code
Summary by cubic
Adds a new
media/animations/workspace with Storybook React scenes for the Desktest CLI launch video and a Playwright +ffmpegrecorder that exports a 1080p H.264 MP4. Also adds a launch demo video link to the root README.New Features
DesktestLaunchAnimationsequencer in Storybook (using@storybook/react-vite, port 6020).media/animations/scripts/record-animation.mjs) usingplaywrightto capture 1920×1080 and transcode to H.264; outputs tomedia/animations/recordings/(gitignored).Migration
media/animations/, install deps and start Storybook on port 6020; updateSTORYBOOK_URLinrecord-animation.mjsonly if you change the port.node media/animations/scripts/record-animation.mjs(requiresffmpegon PATH). Output:media/animations/recordings/desktest-launch.mp4.Written for commit f008007. Summary will update on new commits.